Repository navigation
[agentfabric] Restore generic Member read models - #1139
Open
Kshitija Murudi (kmurudi) wants to merge 1 commit into
Open
Kshitija Murudi (kmurudi) wants to merge 1 commit into
Kshitija Murudi (kmurudi) wants to merge 1 commit into
Conversation
Preserve ACI and Agent Fabric Sandbox reads in July and include AKS in October without reintroducing Member writes. Keep resource arguments and preview API versions unchanged. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: ccc5b7bb-928d-4ff6-8670-b835b1587d66
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
please provide the link to the corresponding pull request in Azure/azure-cli or Azure/azure-cli-extensions:
Companion Azure/azure-cli-extensions follow-up is being opened separately; its link will be added when available. This follows merged #1095 and Azure/azure-cli-extensions#10370, without modifying those merged PRs.
Restore the original version-specific Member GET response schemas while keeping Member create, update, and delete absent:
2026-07-21-preview: ACI and AgentFabricSandbox only.2026-10-07-preview: ACI, AKS, and AgentFabricSandbox, preserving ACI identity blueprint metadata, AKS cluster/endpoints/workload references, and Sandbox response fields.The four JSON/XML pairs are serialized with
CMDConfigurationandAAZSpecsManagerfrom the original pre-narrowing read schemas at5ca157eba, retaining the write-command removal from8e5241a. October remains on RPSaaSMaster baselinea52c4fc4ac8cd197d38a1072704853f485cafb6c; no November/Dev upgrade.Canonical CLI regeneration used Python 3.14 / aaz-dev 4.7.0 and pinned companion source
3b3aa3b6c0bf31ca12a7cbb0adb88092b698a205. All 23 registrations / 33 generated Python files were regenerated in session artifacts and delivered to the companion owner. Only Member show/list/wait differ from that source; the other 30 files are byte-identical. Member wait is rebuilt from the generic show GET model through the AAZ atomic profile APIs, not copied from narrowed Python. All 33 generated-file SHA-256 hashes match the companion checkout. Generated files and consumer-specific custom.py overrides are outside this metadata PR.Validation performed locally (Windows;
Z:maps to this existing AAZ checkout):Result: passed canonical targeted VerifyMetadata on the final fresh-main branch, including command catalog and versioned resource references. The callback avoids Click resolving the short path into Windows-overlong encoded resource paths.
python 'C:\Users\kmurudi\.copilot\session-state\ccc5b7bb-928d-4ff6-8670-b835b1587d66\files\validate_member_models.py'Result: passed 2 tests covering all four full read unions against the original baseline, enum choices/nested fields, model validation and JSON roundtrip/XML serialization parity, no Member writes, unchanged remaining configuration and generated argument builders, full 33-file/23-command inventory, and the exact three-file generated diff. Running the same script with
--revision 8e5241a029924fc997767adb3cddf999dcde495freproduced the four expected pre-fix failures.Result: both passed.
Full repository local verification was also attempted using
verify.callback.__wrapped__(None). It is blocked by Windows MAX_PATH on an unrelated existingsite-recovery protectable-item listencoded resource path (2022-08-01.json). A bounded retry with$env:AAZ_PATH = '\\?\Z:\'failed because the tool concatenates/Commands/readme.mdto that extended path, producing an invalid mixed-separator path. No global settings, unrelated metadata, or installed tooling were changed. The authoritative Ubuntu full VerifyMetadata CI run is pending.No live Azure resource calls or deployments were performed. Companion CLI runtime/build test results are owned and reported by that PR.