Repository navigation
fix(acl): fetch AgentBaker source without git in VHD content test - #10044
Merged
Nishchay (awesomenix) merged 1 commit intoNov 10, 2026
Merged
Conversation
**What this PR does / why we need it**: Azure Container Linux (ACL) is dropping git from its base image in microsoft/azure-container-linux#131. `linux-vhd-content-test.sh` still assumes ACL ships git like Flatcar does. On an image without it, `git clone` fails and the test exits. This moves `AzureContainerLinux` onto the `SKIP_GIT_CLONE=true` path that `AzureLinuxOSGuard` already uses. The test VM downloads `${AGENTBAKER_REPOSITORY_URL%.git}/archive/${GIT_COMMIT_HASH}.tar.gz` with curl and unpacks it with tar. Flatcar is unchanged. ACL images that still have git take the tarball path too, which is fine since curl and tar aren't on the removal list. I ran the same logic as a patch in our internal AKS image build. The VHD content test passed for the ACL AMD64, ARM64 and CVM images built from that ACL PR, none of which have git. Could a maintainer push the commit to a branch here so CI runs? **Which issue(s) this PR fixes**: None filed.
Contributor
Windows Unit Test Results 3 files 21 suites 1m 7s ⏱️ Results for commit 12b2324. |
Contributor
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the Azure Container Linux source-download change.
No open issues 🎉
What changed in this PR
Updates the VHD content test to fetch AgentBaker source without git on Azure Container Linux, accommodating its removal from the base image.
Changes:
- Routes Azure Container Linux through the existing curl-and-tar download path used by AzureLinuxOSGuard.
- Keeps Flatcar’s git-based behavior unchanged and narrows the accompanying comment to Flatcar.
| File | Description |
|---|---|
vhdbuilder/packer/test/linux-vhd-content-test.sh |
Enables SKIP_GIT_CLONE for Azure Container Linux. |
Review effort: Balanced
Contributor
|
Contributor
|
Nishchay (awesomenix)
approved these changes
Nov 10, 2026
Nishchay (awesomenix)
deleted the
user/vinceaperri/acl-linkedin-footprint
branch
November 10, 2026 21:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Azure Container Linux (ACL) is dropping git from its base image in microsoft/azure-container-linux#131.
linux-vhd-content-test.shstill assumes ACL ships git like Flatcar does. On an image without it,git clonefails and the test exits.This moves
AzureContainerLinuxonto theSKIP_GIT_CLONE=truepath thatAzureLinuxOSGuardalready uses. The test VM downloads${AGENTBAKER_REPOSITORY_URL%.git}/archive/${GIT_COMMIT_HASH}.tar.gzwith curl and unpacks it with tar. Flatcar is unchanged. ACL images that still have git take the tarball path too, which is fine since curl and tar aren't on the removal list.I ran the same logic as a patch in our internal AKS image build. The VHD content test passed for the ACL AMD64, ARM64 and CVM images built from that ACL PR, none of which have git.
Could a maintainer push the commit to a branch here so CI runs?
Which issue(s) this PR fixes:
None filed.