Repository navigation
feat: add additional Linux node sysctl settings - #10043
Open
Thibault Cohen (titilambert) wants to merge 1 commit into
Open
Thibault Cohen (titilambert) wants to merge 1 commit into
Thibault Cohen (titilambert) wants to merge 1 commit into
Conversation
Combine tcp_wmem, bpf_jit_limit, and nr_hugepages support in ANC. Preserve optional field presence, regenerate protobuf code, and include the tests from all three child commits. ADO: 30575488, 38453992, 24091438 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
This change is part of the following stack: Change managed by git-spice. |
Contributor
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
Contributor
Windows Unit Test Results 3 files 21 suites 51s ⏱️ Results for commit a4cf50e. |
Contributor
|
Contributor
|
Contributor
|
Mark Ibrahim (mxj220)
approved these changes
Nov 10, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block approval of the sysctl transport and rendering changes.
No open issues 🎉
1 file not reviewed
aks-node-controller/pkg/gen/aksnodeconfig/v1/custom_linux_os_config.pb.go: Generated file
What changed in this PR
Extends AKS Node Controller’s Linux sysctl configuration transport and rendering to support vm.nr_hugepages, net.core.bpf_jit_limit, and net.ipv4.tcp_wmem. API validation and kernel acceptance checks remain outside this change’s scope.
Changes:
- Adds optional protobuf fields and regenerated Go bindings, using
int64for the BPF JIT limit. - Renders explicitly supplied settings while preserving zero and empty values.
- Adds round-trip tests covering custom values, field presence, and BPF limits exceeding
int32.
| File | Description |
|---|---|
aks-node-controller/proto/aksnodeconfig/v1/custom_linux_os_config.proto |
Defines the three optional sysctl fields. |
aks-node-controller/pkg/gen/aksnodeconfig/v1/custom_linux_os_config.pb.go |
Updates generated fields, getters, and descriptors. |
aks-node-controller/parser/helper.go |
Maps provided values into sysctl configuration. |
aks-node-controller/parser/helper_test.go |
Adds round-trip coverage for the new settings. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds ANC support for three configurable Linux sysctls:
vm.nr_hugepages,net.core.bpf_jit_limit, andnet.ipv4.tcp_wmem.Adds optional protobuf fields, regenerates Go bindings, and maps explicitly provided values into the generated sysctl configuration. Uses int64 for the BPF JIT limit and preserves explicit zero and empty values. Includes round-trip tests for the three settings. This change adds configuration transport and rendering, not API validation or kernel acceptance checks.
Which issue(s) this PR fixes: