Repository navigation
feat(aks-node-controller): add remaining kubelet protos (excl. memswap) - #10042
Open
Mark Ibrahim (mxj220) wants to merge 1 commit into
Open
Mark Ibrahim (mxj220) wants to merge 1 commit into
Mark Ibrahim (mxj220) wants to merge 1 commit into
Conversation
Contributor
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
Contributor
Windows Unit Test Results 3 files 21 suites 1m 14s ⏱️ Results for commit 3837c1a. |
Contributor
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block the kubelet memory-manager configuration additions.
No open issues 🎉
1 file not reviewed
aks-node-controller/pkg/gen/aksnodeconfig/v1/kubelet_config.pb.go: Generated file
What changed in this PR
Extends the aks-node-controller kubelet configuration schema with memory-manager settings, without changing defaults or migrating existing kubelet flags.
Changes:
- Adds
memory_manager_policyand per-NUMA-nodereserved_memoryfields while preserving existing field numbers. - Regenerates Go protobuf types and descriptors for the new fields.
- Adds a serialization test verifying that an explicitly configured NUMA node ID of
0is preserved.
| File | Description |
|---|---|
| aks-node-controller/proto/aksnodeconfig/v1/kubelet_config.proto | Defines memory-manager policy and memory reservations. |
| aks-node-controller/pkg/gen/aksnodeconfig/v1/kubelet_config.pb.go | Updates generated Go bindings and protobuf descriptors. |
| aks-node-controller/parser/kubelet_config_test.go | Tests serialization of memory settings with NUMA node zero. |
Review effort: Balanced
Contributor
|
Contributor
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Extend the kubelet configuration protobuf schema with two more optional fields requested by customers:
Regenerated the corresponding Go protobuf code.
Added one unit test to ensure NUMA node 0 is preserved by protobuf (0 is meaningful for NUMA nodes, not an empty value)
Existing field numbers remain unchanged.
This change adds schema support only; it does not change defaults or migrate existing kubelet flags.
Which issue(s) this PR fixes:
Fixes #