Repository navigation
Conversation
…ting nohup launcher
injectWriteFilesEntriesToBoothookCustomData spliced the write_files block at
the index of "/bin/bash .../aks-node-controller-launcher.sh", which is mid-line
right after "nohup ". That left a bare "nohup" ("nohup: missing operand") and
failed the boothook, so Ubuntu2204_PreProvision_CustomCAFailure timed out
instead of exiting 161. Insert at the start of the logger line preceding the
launcher block (falling back to the start of the launcher/systemctl line).
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
Windows Unit Test Results 3 files 21 suites 58s ⏱️ Results for commit 8a566f6. |
Contributor
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the E2E cloud-boothook injection fix.
No open issues 🎉
What changed in this PR
Fixes cloud-boothook file injection in AgentBaker’s E2E harness so it does not split the nohup launcher command, addressing the reported CustomCAFailure gate failures. Production code paths are unchanged.
Changes:
- Inserts file-writing commands at a line boundary, preferring the logger before the launcher branches and retaining launcher/systemctl fallbacks.
- Adds regression checks for launcher integrity, insertion order, and Bash syntax with and without the logger line.
| File | Description |
|---|---|
e2e/scenario/vmss.go |
Selects an insertion marker and moves the insertion point to its line start. |
e2e/scenario/vmss_test.go |
Adds regression tests preserving the launcher command and checking rendered Bash syntax. |
Review effort: Balanced
Contributor
|
Contributor
|
auto-merge was automatically disabled
November 6, 2026 18:48
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix
injectWriteFilesEntriesToBoothookCustomDatain the e2e harness. It was splicing theCustomDataWriteFilesblock into the middle of a line in the cloud-boothook.Why
The function inserted the block at the index of
/bin/bash /opt/azure/containers/aks-node-controller-launcher.sh. That position is right afternohupon the same line, so the rendered boothook became:The boothook then fails with
nohup: missing operand(seen in the serial console), so aks-node-controller never runs.Because of this,
Test_Ubuntu2204_PreProvision_CustomCAFailurehas been failing on every Linux PR gate since ~11-05. The VMSS create times out (~1039s) instead of CSE exiting with the expected status 161. Examples: #9736, #10002–#10009, #9998, #9966, #9833.How
logger -t aks-boothook "launching aks-node-controller ..."line, which precedes the launcherif/else. The files are then written whichever branch starts aks-node-controller.systemctlline.nohup ... launcher.shline stays intact and that the rendered boothook passesbash -n.Test-only change; no production code paths are affected.