Repository navigation
fix(chat): link-only messages collapse to the artwork - #14782
Merged
Merged
Conversation
#14749 wrapped each message bubble in a row for the group sender avatar. That row shrinks to fit, so a link-only bubble's min(448px, 100%) width had nothing to resolve against and the track or playlist card collapsed to its artwork. Make the row full width and justify it by author. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #14749 (group DMs), a message that is only a track or playlist link renders as a narrow card showing just the artwork and repost count, in 1:1 chats too. Messages with text plus a link look fine because the text sets the bubble's width. Prod predates #14749, so it only shows on RC.
Cause: #14749 wrapped every bubble in a
Flexrow so the group sender's avatar can sit beside it. That row is a shrink-to-fit flex item of the message column, so the link-only bubble'swidth: min(448px, 100%)resolves against the row's content width instead of the list.Fix: the row is now
w='100%', justifiedflex-endfor your own messages andflex-startfor others. Text bubbles keep their content width (max-widthis unchanged).Checked: in a static reproduction of the bubble CSS, the current layout gives the link-only bubble 354px (and less with the real unfurl contents), and the fix restores 448px, matching the pre-#14749 layout. Author bubbles stay right-aligned and a text-only bubble keeps its 172px content width. Not yet checked in the running app: please look at a link-only message on RC after merge.
🤖 Generated with Claude Code