Repository navigation
[tech-debt 4/5 higher risk] sdk: handle async errors in storage, node selection, relay and chats - #14777
Merged
Conversation
…hats From #14665: - Storage: forward tus onSuccess polling failures to reject; stop polling after abort - StorageNodeSelector: drop the bootstrap ordering when the node list refreshes - Request signature middleware: clear the cached signature on errors - SolanaRelayWalletAdapter: reset connecting when getFeePayer throws - SolanaRelay: don't mask ResponseError with a body parse error - SolanaClient: round the priority fee so BigInt() doesn't throw - ChatsApi: don't cache rejected public key lookups; catch websocket handler errors Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 6fe83a6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fourth of five PRs that re-ship #14665 on current main, ordered from lowest to highest risk. Branched off main, independent of the others.
What's in it
sdk error-handling fixes, with a patch changeset, so merging this publishes an sdk version.
onSuccess, so a polling failure became an unhandled rejection andstart()never settled. Polling results now go toresolve/reject.try, so the abort error was caught and retried every 3s for up to an hour. It's checked before thetry.SolanaRelayWalletAdapter.connect():connectingstayedtrueforever ifgetFeePayerthrew.SolanaRelay.relay(): a non-JSON or null error body replaced the realResponseErrorwith a parse error.SolanaClient.buildTransaction(): the 1.5x priority multiplier can produce a fractional fee, andsetComputeUnitPricethrows on it when converting toBigInt. The fee is rounded. New test covers it.Why this tier
Published package, and uploads now reject in cases where they used to hang. Callers that never handled a rejection from
upload.start()will now see one.Dropped from #14665
updateAvailableStorageNodesunhandled rejection: main now fetches the node list lazily with its own catch.isNodeHealthygetting the sdk logger: skipped here to keep this PR independent of tier 1, which moves the function.Verified
tscandeslint(changed files): clean.Not verified
No end-to-end upload against a real node.
🤖 Generated with Claude Code