Repository navigation
[tech-debt 1/5 low risk] Remove dead code, @ts-ignores and stale terminology - #14774
Merged
Merged
Conversation
Low-risk part of #14665: unused files and exports, @ts-ignore replaced with types, discovery/content node comments renamed to validator node, shared mobile skip/restart constants, web hooks README. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of five PRs that re-ship #14665 on current main, ordered from lowest to highest risk. Each one is branched off main and they don't depend on each other.
What's in it
Code removal and type/comment cleanup only. Nothing here should change runtime behavior.
sdk (internal files only, nothing exported from the package entry point)
utils/deepPartial,utils/localStorage,utils/object,utils/uuid.getNStorageNodes;isNodeHealthymoves to its own file unchanged.EntityManagerClientuses the existingwait()helper.generatePreviewnow throwsNo validator node available. The relay quote error names the right param (audioInputAmount).harmony
FilterButtonKeyHandler(not exported) and an emptyuseEffectinFollowButton.findAncestoris justel.closest(). The fallback was for browsers withoutclosest.common
useUpdateCollection,useUnfollowUser,usePremiumTracks,reactions/utils,models/Activity, the emptyformatTrackTimestamp.addTransferToUserBankInstructionsandisDirectRouteAvailable, AUDIO balance sagas, and others).@ts-ignores with types in the notification adapter,useInstanceVar,commonPasswordCheckanduseUSDCTransactions(Object.assignonto the same result object, as before).mobile
AudioPlayerandNowPlayingDrawerincomponents/audio/constants.ts.@ts-ignores that are no longer needed, and some dead comments.web
useScript; fix the hooks README.Every removed export, file and flag was re-grepped across all packages on current main before deleting.
Why this tier
Deletions of code with no callers, type-only changes and comments. If something is wrong here it fails at compile time, not at runtime.
Dropped from #14665 because main already covers it
IOS_USDC_PURCHASE_ENABLED,REACT_QUERY_SYNC,COLLAPSED_EXPLORE_HEADERflags: already removed on main (chore: remove dead crypto code, unused deps and unread remote-config keys #14671 and flag cleanups).SLIPPAGE_TOLERANCE_EXCEEDED_ERRORinservices/Jupiter.ts: already removed.SolanaAddressSchema@ts-ignore: main rewrote it with a base58 check.useTrackPageLineup,WalletClientandstoreContext.Verified
tsc: sdk and harmony clean. common, mobile and web each show the same errors as origin/main in this checkout, all in untouched files (a vitest type in a common test,SelectablePillFieldin web,ThemeProviderin mobile).eslinton changed files: clean.store/upload/selectors.test.ts(7 tests) fails the same way on origin/main.Not verified
Not run on a device or in a browser.
🤖 Generated with Claude Code