Skip to content

fix(web): turn off the React Compiler on web (rollback of #14730) - #14740

Closed
dylanjeffers wants to merge 1 commit into
mainfrom
revert/web-react-compiler
Closed

dylanjeffers wants to merge 1 commit into
mainfrom
revert/web-react-compiler

Conversation

@dylanjeffers

@dylanjeffers dylanjeffers commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Mitigates a production issue: likes, reposts and comments on web are reported as not persisting (reported by Michael Cullen, Nov 4).

#14730 is the only web change in production since Nov 3. It reached audius.co at 20:00 UTC on Nov 3, turned the React Compiler on for web for the first time (about 2,100 compiled memo caches, including the shared @audius/common hooks web loads as source), and its description notes that signed-in flows weren't tested before the production deploy. No API, identity service, or social-path changes shipped in the same window.

This removes babel-plugin-react-compiler from the web Vite config, so web is no longer compiled, as before Nov 3.

Why not a straight revert

Reverting #14730 changes package-lock.json. Any lockfile change on main triggers Mobile CI/CD, which publishes a mobile OTA to the RC channel automatically. This change touches only packages/web/vite.config.ts, so no mobile build or OTA runs. @vitejs/plugin-react stays; without the compiler plugin it does a plain JSX transform.

Not yet confirmed

The compiler is the leading suspect but isn't proven to be the cause. If likes start sticking again on web after this deploys, that confirms it. If they don't, the problem is in the write path.

Testing

  • Relying on Web CI/CD for the build and tests
  • After deploy: the production bundle should have no memo_cache_sentinel markers

— 🏹 Legolas

🤖 Generated with Claude Code

@changeset-bot

changeset-bot Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 936e265

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@socket-security

socket-security Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

No dependency changes detected. Learn more about Socket for GitHub.

👍 No dependency changes detected in pull request

Removes babel-plugin-react-compiler from the web Vite config while we
investigate likes, reposts and comments not persisting on web after
#14730 reached production. Keeps @vitejs/plugin-react so package.json
and package-lock.json are unchanged, which keeps the mobile workflow
(and its automatic OTA on main) from running.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@dylanjeffers
dylanjeffers force-pushed the revert/web-react-compiler branch from 35c9f32 to 936e265 Compare November 5, 2026 00:21
@dylanjeffers dylanjeffers changed the title Revert "feat(web): actually run the React Compiler (#14730)" fix(web): turn off the React Compiler on web (rollback of #14730) Nov 5, 2026
@dylanjeffers

Copy link
Copy Markdown
Contributor Author

Closing: the React Compiler fix shipped and is live, so this rollback isn't needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant