Repository navigation
feat(web): waveform with comment avatars on desktop track tiles - #14717
Merged
Merged
Conversation
Large desktop track tiles get a bar waveform between the title and the stats row, behind the track_tile_waveform flag (default on in dev, off in prod). Clicking the waveform seeks the playing track or starts the tile at that point. Comments with a track timestamp sit on the baseline as avatars; hover shows the comment, click opens it on the track page. No node serves audio peaks yet, so the shape is synthesized from the track id. Comments are fetched once per tile, only for tiles with comments that have scrolled near the viewport. The timestamped-comments hook moves from mobile into common so both the Now Playing scrubber and the web tile share it. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Large desktop track tiles get a SoundCloud-style bar waveform between the title and the stats row. Comments with a track timestamp sit on the baseline as avatars.
?commentId=; the/commentssubroute is mobile-only and redirects on desktop).useTimestampedCommentsmoves from mobile into@audius/common/apiso the Now Playing scrubber and the tile share it.No node serves audio peaks, so the bar shape is synthesized from the track id with a seeded generator. It is stable per track but not the audio. Real peaks need a backend endpoint.
Flag
track_tile_waveform: code default on in development, off in production. The Optimizely flag exists in Audius Dapp with a Production rule delivering Off, so this ships dark.Test plan
TrackTile.test.tsxpasses🤖 Generated with Claude Code