Skip to content

Feature request: dark player color option for embeds - #14715

Draft
dylanjeffers wants to merge 1 commit into
mainfrom
feature-request/embed-dark-theme
Draft

dylanjeffers wants to merge 1 commit into
mainfrom
feature-request/embed-dark-theme

Conversation

@dylanjeffers

Copy link
Copy Markdown
Contributor

Summary

Community feature request from Discord #feature-requests (toby / remixify, Jun 2-3, 2026): "add options to configure the embed a little more ... size, light/dark modes".

Sizes already exist (flavor=card|compact|tiny). This adds a dark color option:

  • Embed player: new theme query param. theme=dark swaps the artwork-tinted background for neutral dark surfaces (Harmony default-dark surface1 for the card, surface2 for collection rows). Anything else, or no param, keeps today's artwork color, so existing embed codes are unchanged.
  • Web embed modal: new Player Color control (Artwork / Dark) that writes &theme=dark into the embed code and updates the preview. Hidden for the Tiny size, which has no background.
  • Small hexToRgb util so the dark colors use the rgb() form that Card and shadeColor parse.

Test plan

  • jest for hexToRgb
  • eslint clean for packages/embed; tsc and eslint clean for packages/web
  • Manually: open the embed modal for a track and an album, toggle Player Color, confirm the preview and copied code; load /embed/track/<id>?flavor=card&theme=dark and ?flavor=compact&theme=dark

Open questions

  • The request also asked for a light mode. That needs dark text, a different play button treatment and scrubber colors on a white card, which is a design call, so I left it out.
  • Harmony's default-dark surface1 and surface2 are very close (#0F0F0F / #141414), so collection rows are subtle on the dark card. Happy to pick different tokens.

Generated by Claude Code

Adds a `theme=dark` query param to the embed player that swaps the
artwork-tinted background for neutral dark surfaces (Harmony
default-dark surface1/surface2), and a Player Color control (Artwork /
Dark) to the web embed modal that writes it into the embed code. The
default is unchanged, so existing embed codes render as before.

Requested in Discord #feature-requests (Jun 2-3, 2026).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HvrdX7CeHau9gA4PhK8HYq
@changeset-bot

changeset-bot Bot commented Oct 27, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 21dac04

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant