Repository navigation
Feature request: dark player color option for embeds - #14715
Draft
dylanjeffers wants to merge 1 commit into
Draft
dylanjeffers wants to merge 1 commit into
dylanjeffers wants to merge 1 commit into
Conversation
Adds a `theme=dark` query param to the embed player that swaps the artwork-tinted background for neutral dark surfaces (Harmony default-dark surface1/surface2), and a Player Color control (Artwork / Dark) to the web embed modal that writes it into the embed code. The default is unchanged, so existing embed codes render as before. Requested in Discord #feature-requests (Jun 2-3, 2026). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HvrdX7CeHau9gA4PhK8HYq
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Community feature request from Discord #feature-requests (toby / remixify, Jun 2-3, 2026): "add options to configure the embed a little more ... size, light/dark modes".
Sizes already exist (
flavor=card|compact|tiny). This adds a dark color option:themequery param.theme=darkswaps the artwork-tinted background for neutral dark surfaces (Harmonydefault-darksurface1for the card,surface2for collection rows). Anything else, or no param, keeps today's artwork color, so existing embed codes are unchanged.&theme=darkinto the embed code and updates the preview. Hidden for the Tiny size, which has no background.hexToRgbutil so the dark colors use thergb()form thatCardandshadeColorparse.Test plan
jestforhexToRgbeslintclean forpackages/embed;tscandeslintclean forpackages/web/embed/track/<id>?flavor=card&theme=darkand?flavor=compact&theme=darkOpen questions
surface1andsurface2are very close (#0F0F0F/#141414), so collection rows are subtle on the dark card. Happy to pick different tokens.Generated by Claude Code