Repository navigation
fix(flags): default track_rows off so it can actually be turned off - #14708
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Flips the
track_rowscode default tofalse. This turns the dense TrackRow UI (Trending, profile, search, collections, Library, dashboard on web and mobile) back to tiles in production.Why
The rows went live on web prod today, and the Optimizely flag can't turn them off on its own.
getFeatureEnabledreturns(isFeatureEnabled(flag) || ...) ?? defaultVal, so when Optimizely saysfalsethe result isundefined, which then falls back to the code default. Only an Optimizelytrueever overrides the default. With the default attrue, the "remote kill switch" did nothing.This needs both halves:
false)track_rowsflag turned off in Optimizely production. It's currently servingonto 100% (datafile revision 3207). Until that's done, it overrides this default back to on.After that, Optimizely
trueturns it back on, and this time the switch works both ways.now_playing_commentshas the same "default on, remote flag is the kill switch" comment and the same problem. That's left as is here.🤖 Generated with Claude Code