Skip to content

fix: improve Herman portrait framing on the team page - #28

Merged
chengjiahao1234 merged 1 commit into
mainfrom
feature/team-herman-photo-framing
Oct 1, 2026
Merged

chengjiahao1234 merged 1 commit into
mainfrom
feature/team-herman-photo-framing

Conversation

@chengjiahao1234

Copy link
Copy Markdown
Collaborator

Type of Change

  • Bug Fix

Summary

Fix Herman Tcheneghon Motcheyo's portrait framing on the team page so his full head and shoulders are visible.

Changes Made

  • _data/phd_students.yml: set Herman's portrait position to center top and document the optional field.
  • _includes/team-grid.html: support an optional per-member photo_position, while preserving centered cropping for other members and fallback images.
  • Keep the original portrait, team ordering, contact details, and profile links unchanged.

Testing Checklist

  • Desktop (1920x1080)
  • Tablet (768x1024)
  • Mobile (375x667)
  • Light theme
  • Dark theme
  • All team images load; existing link targets remain unchanged
  • No browser console errors or layout overflow
  • Ran bundle exec jekyll serve successfully
  • Passed YAML regression checks and git diff --check
  • Verified other members retain their existing portrait positioning

Screenshots

Before/after and responsive screenshots were captured locally; they are not attached to this PR.

Related Issues

None.

Additional Notes

This changes the displayed crop only; it does not modify the source photograph. The optional positioning field is documented in the YAML and shared include.


By submitting this PR, I confirm:

  • I have tested these changes locally
  • I have followed the code standards in DEVELOPMENT.md
  • I have updated documentation where needed
  • I am ready for this to be reviewed and merged

@chengjiahao1234
chengjiahao1234 merged commit 3b29725 into main Oct 1, 2026
1 check passed
@chengjiahao1234
chengjiahao1234 deleted the feature/team-herman-photo-framing branch October 1, 2026 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant