Skip to content

Update default model, OpenAI request options, and JET compat #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
terasakisatoshi merged 1 commit into from
Sep 24, 2026
Merged

Update default model, OpenAI request options, and JET compat #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,11 @@ Scratch = "6c6a2e73-6563-6170-7368-637461726353"
[compat]
Aqua = "0.8"
Documenter = "1"
JET = "0.9, 0.11"
JET = "0.9, 0.11, 0.12"
Markdown = "1"
OpenAI = "0.10.1, 0.11, 0.12"
ReTestItems = "1.31.0"
SHA = "0.7.0"
SHA = "0.7.0, 1"
Scratch = "1.2.1"
Test = "1"
julia = "1.10"
Expand Down
3 changes: 2 additions & 1 deletion src/openai.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
const DEFAULT_MODEL = Ref{String}("gpt-4o-mini-2024-07-18")
const DEFAULT_MODEL = Ref{String}("gpt-6-luna")

function default_lang()
return DEFAULT_LANG[]
Expand Down Expand Up @@ -66,6 +66,7 @@ function translate_with_openai(
Dict("role" => "system", "content" => system_promptfn(lang)),
Dict("role" => "user", "content" => string(doc)),
];
reasoning_effort = "none",

@chatgpt-codex-connector chatgpt-codex-connector Bot Sep 24, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Only send reasoning_effort to models that support it

This option is now attached to every request, including calls made after switchmodel! selects a non-reasoning model such as the previous gpt-4o-mini-2024-07-18, or when OPENAI_BASE_URL_OVERRIDE targets a compatible backend that does not implement this field. Such endpoints reject the request rather than translating, so the option should be conditional on a supporting model/provider or exposed as an opt-in request option.

Useful? React with 👍 / 👎.

temperature = 0,
)
content = c.response[:choices][begin][:message][:content]
Expand Down
2 changes: 1 addition & 1 deletion test/jet_tests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@
using Test
using JET
@testset "JET" begin
JET.test_package(DocstringTranslation; target_defined_modules = true)
JET.test_package(DocstringTranslation; target_modules = (DocstringTranslation,))
end
end
Loading