Repository navigation
NVIDIA OpenShell install guide review - #3890
Merged
jasonrandrews merged 7 commits intoOct 12, 2026
Merged
jasonrandrews merged 7 commits into
jasonrandrews merged 7 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The filesystem and network boundary steps probably exceed the scope of an install guide a bit, but it's a useful exercise, so I've retained them. I've grouped the boundary tests under "verify" and updated subheads accordingly. After testing the steps, I figured that readers can use the same sandbox for all verification, so I updated commands and outputs accordingly. I can reintroduce the steps if necessary, but it seems okay to use one sandbox to verify that the install was successful and the expected boundaries are in place.
There was also a sentence referring to an OpenShell LP. I couldn't find the LP. Might've been a hallucination or a reference to draft content, so I removed the sentence. I made other standard editorial updates for style, consistency etc.