Repository navigation
Jk review feedback - #27
Merged
Merged
Conversation
Make CMSIS-Toolbox 2.15.0 the minimum version As a result remove the misc flags for CLANG Make debug adapter work for FVP on Windows and Linux out of the box.
macOS user need to remove the .mac extension
use CMSIS-Toolbox 2.15.0
With `model: FVP_Corstone_SSE-320` the extension generates launch.json on Windows and Linux, so .gitignore keeps launch.json.mac instead of launch.json (the regenerated file showed up as untracked). The README, the csolution, fvp.sh, launch.json.mac and mlops-flow.md now describe fvp.sh plus launch.json.mac as the macOS setup rather than the default, and the README asks for CMSIS-Toolbox 2.15.0.
Contributor
|
Reviewed and tested; looks good, thanks.
I added one commit (fd6675b) on top:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Matthias, please review my proposed changes. This makes FVP work for Windows and Linux out of the box.
I also made CMSIS-Toolbox 2.15.0 the minimum version and removed the CLANG misc options as the command line was fixed and does not longer ends in an internal compiler error.