Skip to content

fix(amazonq): ask before modifying workspace configuration files - #2944

Closed
hezelin-work wants to merge 1 commit into
feature/OHIfrom
fix/workspace-config-write-approval
Closed

hezelin-work wants to merge 1 commit into
feature/OHIfrom
fix/workspace-config-write-approval

Conversation

@hezelin-work

Copy link
Copy Markdown

Problem

Changes to workspace configuration files did not ask for approval.

Solution

Ask before fsWrite or fsReplace modifies files in the .amazonq, .vscode, or .git folders of the workspace. Memory bank generation can still write its own files.

Behavior change: the agent now asks before editing files such as .vscode/settings.json.

Testing: added unit tests.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter

codecov-commenter commented Oct 16, 2026 •

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@hezelin-work
hezelin-work marked this pull request as ready for review October 16, 2026 20:24
@hezelin-work
hezelin-work requested a review from a team as a code owner October 16, 2026 20:24
- Ask before fsWrite or fsReplace modifies files in .amazonq, .vscode,
  or .git folders in the workspace, including linked folders.
- Memory bank generation can still write its own files.
@hezelin-work
hezelin-work force-pushed the fix/workspace-config-write-approval branch from 8a5bc4d to 9cf4449 Compare October 16, 2026 21:45
@hezelin-work

Copy link
Copy Markdown
Author

Moved to #2953.

@hezelin-work
hezelin-work deleted the fix/workspace-config-write-approval branch October 20, 2026 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants