Repository navigation
Antalya 26.8: Antalya-26:6 - iceberg v3: rewriteFiles - Added logic to merge small files into bins - #2737
Open
zvonand wants to merge 2 commits into
Open
Antalya 26.8: Antalya-26:6 - iceberg v3: rewriteFiles - Added logic to merge small files into bins#2737zvonand wants to merge 2 commits into
zvonand wants to merge 2 commits into
Conversation
…next commit) --- Original cherry-pick message follows: Merge pull request #2420 from Altinity/iceberg_rewrite_files_compaction Antalya-26:6 - iceberg v3: rewriteFiles - Added logic to merge small files into bins # Conflicts: # src/Storages/ObjectStorage/DataLakes/Iceberg/Compaction.cpp # src/Storages/ObjectStorage/DataLakes/Iceberg/IcebergMetadata.cpp # src/Storages/ObjectStorage/DataLakes/Iceberg/IcebergWrites.cpp # src/Storages/ObjectStorage/DataLakes/Iceberg/IcebergWrites.h # src/Storages/ObjectStorage/DataLakes/Iceberg/Utils.cpp # src/Storages/ObjectStorage/DataLakes/Iceberg/Utils.h
Kept base `overwriteIsPositionDeleteOnly` check in `tryGetAppendUpdate`. Kept the `CLICKHOUSE_CLOUD` branch of `IcebergMetadata::optimize`, with the PR's bin-pack logic in the `#else` branch. Adapted: `IcebergMetadata::optimize` uses `external_storages` (renamed from `secondary_storages` on antalya-26.8) Adapted: `ManifestListEntryCounts` keeps base `added_snapshot_id`/`added_sequence_number`; base `counts_are_added` callers in `Compaction.cpp` translated to added_*/existing_* counts Adapted: `tryWriteMetadataFileAndVersionHint` takes base `version_hint_names_metadata_file` out-param and keeps base hint-retry warning and `UNSUPPORTED_METHOD` rethrow
zvonand
added
releasy
59 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Implement bin-packing
ReWriteFilesoperation that Identifies small data files below a target size threshold(defined in Settings), groups them and merges to a large file, creates a snapshot that marks the old ones as DELETED and the new larger merge file as ADDED.Leave all other files, manifests, and history untouched (#2420 by @subkanthi).
CI/CD Options
Exclude tests:
Regression jobs to run:
Cherry-picked from #2420.