Repository navigation
[OGUI-746] URL live mode parameter - #2708
Draft
Houwie7000 wants to merge 7 commits into
Draft
Houwie7000 wants to merge 7 commits into
Houwie7000 wants to merge 7 commits into
Conversation
Houwie7000
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
isaachilly
marked this pull request as draft
September 21, 2026 16:32
isaachilly
changed the base branch from
dev
to
improv/ILG/OGUI-1926/Clean-up-logic-for-query-buttons
September 29, 2026 12:35
isaachilly
added this pull request to stack #3645
September 29, 2026 12:35
Button style, live icon, browser tab title and auto-scroll were set inside the click handler via module-level state, so any mode change not triggered by a click left the UI stale. Derive them from log.activeMode in the model/view instead.
isaachilly
force-pushed
the
improvement/Houwie7000/OGUI-746/url-parameter-direct-livemode
branch
2 times, most recently
from
September 30, 2026 15:00
10200f9 to
84b4fd5
Compare
isaachilly
changed the title
isaachilly
force-pushed
the
improvement/Houwie7000/OGUI-746/url-parameter-direct-livemode
branch
from
October 13, 2026 13:23
84b4fd5 to
cf65f55
Compare
Base automatically changed from
improv/ILG/OGUI-1926/Clean-up-logic-for-query-buttons
to
dev
October 15, 2026 07:33
isaachilly
force-pushed
the
improvement/Houwie7000/OGUI-746/url-parameter-direct-livemode
branch
from
October 15, 2026 07:33
cf65f55 to
e0ff4f2
Compare
…vemode' of github.com:AliceO2Group/WebUi into improvement/Houwie7000/OGUI-746/url-parameter-direct-livemode
…/OGUI-746/url-parameter-direct-livemode
parseLocation is now async and awaits profile loading before showing filter errors. Profile loading and filter parsing now run together, so a profile can be combined with filters and live=true is no longer ignored for profiles. Also show a warning when a query ran before live mode was ready, instead of silently staying in query mode. updateRouteOnModelChange now keeps live=true in the URL while in Running mode.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have JIRA issue created
Ticket:
Accept a
liveURL parameter. When it is set to true, attempt to start live mode as soon as its dependencies have allow.No mention if the live mode param should then be removed from the URL or stay and act as a shareable parameter.
Needed so the AliECS GUI can link from a running environment to InfoLogger GUI in live mode with autoscroll (OGUI-722).
Code:
Previously, the Query/Live mode switching and their button styling were handled in the
commandLogsview bytoggleButtonStates, which stored the button state in module-level variables. Starting live mode from the URL meant interacting with the view to update these variables, which prom[ted a refactor to extract logic from the view to a model.activeMode.Logmodel.Reviewer:
The reviewer can test using this URL (remove runNumber to match more logs, but this is the specific use case the ticket mentions):
http://localhost:8080/?q=%7B%22timestamp%22%3A%7B%22since%22%3A%22-1h%22%7D%2C%22run%22%3A%7B%22match%22%3A%22248025%22%7D%2C%22severity%22%3A%7B%22in%22%3A%22I%20W%20E%20F%22%7D%7D&live=true