Repository navigation
[QC-1260] Consider handling better invalid JSON from ccdbApi->list - #2703
Open
Barthelemy wants to merge 1 commit into
Open
Barthelemy wants to merge 1 commit into
Barthelemy wants to merge 1 commit into
Conversation
The json error was already handled in the sense that it was not crashing and it was logging a human readable error. I added a test and added a bit more output in case we don't find the objects we are looking for in the listing.
knopers8
approved these changes
Nov 2, 2026
knopers8
left a comment
knopers8
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, it's probably all we can do on the QC side.
I still believe that CcdbApi::list should not return an HTML-formatted error as a return value (especially that we ask for "Application/JSON"), but just throw an exception, so the caller knows an error happened before validating its inputs. It's not for this PR though.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The json error was already handled in the sense that it was not crashing and it was logging a human readable error. I added a test and added a bit more output in case we don't find the objects we are looking for in the listing.