Repository navigation
[PWGHF] Support generator-only derived data without MC centrality - #18557
Merged
Merged
Conversation
monamelop
requested review from
NicoleBastid,
alibuild,
deepathoms,
fcatalan92,
fcolamar,
fgrosa,
hahassan7,
mfaggin,
mmazzilli and
vkucera
as code owners
November 2, 2026 16:10
monamelop
requested review from
apalasciano,
gluparel,
jpxrk,
singhra1994,
stefanopolitano,
xinyepeng and
zhangbiao-phy
as code owners
November 2, 2026 16:10
|
O2 linter results: ❌ 0 errors, |
vkucera
requested changes
Nov 2, 2026
vkucera
left a comment
vkucera
left a comment
Collaborator
There was a problem hiding this comment.
Hi @monamelop , thanks for the improvement. Please see my suggestion to avoid duplication below.
Co-authored-by: Vít Kučera <26327373+vkucera@users.noreply.github.com>
vkucera
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow generator-only processing in the D0 and Ds derived-data creators without requiring the MC centrality table.
Changes:
PWGHF/TableProducer/derivedDataCreatorD0ToKPi.cxx
PWGHF/TableProducer/derivedDataCreatorDsToKKPi.cxx
PWGHF/Utils/utilsDerivedData.h
The reconstructed-MC process functions keep their existing collision-table inputs.
@vkucera Could you please take a look? Thanks!