Repository navigation
Conversation
Follow RecoDecay::getParticleOrigin with its default arguments and classify nonzero origins as HF, as suggested by Fabrizio. Remove the custom PDG and ancestry helpers without changing the remaining origin routing. Co-authored-by: Fabrizio Grosa <fabrizio.grosa@cern.ch>
FDUEnrich
requested review from
NicoleBastid,
alibuild,
deepathoms,
fcatalan92,
fcolamar,
fgrosa,
hahassan7,
jpxrk,
mfaggin,
mmazzilli and
vkucera
as code owners
October 27, 2026 18:23
FDUEnrich
requested review from
apalasciano,
ariedel-cern,
dimihayl,
dsarkaralice,
gluparel,
lauraser,
singhra1994,
stefanopolitano,
victor-gonzalez,
xinyepeng and
zhangbiao-phy
as code owners
October 27, 2026 18:23
|
O2 linter results: ❌ 0 errors, |
xinyepeng
approved these changes
Oct 28, 2026
xinyepeng
enabled auto-merge (squash)
October 28, 2026 00:46
lauraser
reviewed
Oct 30, 2026
|
|
||
| /// Classify true kaons from the correct collision for the DCA templates. | ||
| template <typename T> | ||
| inline int getKaonOrigin(T const& particles, typename T::iterator const& particle) |
Collaborator
There was a problem hiding this comment.
This function is used only y HF. Would it be possible to move this template to the HF charm producer instead of implementing it here?
lauraser
requested changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separate kaon MC DCAxy templates into HF and LF using
RecoDecay::getParticleOrigin. Include Omega contributions in LF; leave other particle classifications unchanged.