Skip to content

[PWGCF] Add region-aware initialisation to FlowPtContainer, mimicking GFW flow initialisation - #18426

Merged
EmilGorm merged 4 commits into
AliceO2Group:masterfrom
EmilGorm:flow-pt-cont-feat
Oct 23, 2026
Merged

EmilGorm merged 4 commits into
AliceO2Group:masterfrom
EmilGorm:flow-pt-cont-feat

Conversation

@EmilGorm

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions github-actions Bot added the pwgcf label Oct 22, 2026
@github-actions github-actions Bot changed the title Add region-aware initialisation mimicing GFW flow initialisation [PWGCF] Add region-aware initialisation mimicing GFW flow initialisation Oct 22, 2026
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 5 warnings, 🔕 13 disabled

@EmilGorm EmilGorm changed the title [PWGCF] Add region-aware initialisation mimicing GFW flow initialisation [PWGCF] Add region-aware initialisation to FlowPtContainer, mimicking GFW flow initialisation Oct 22, 2026
@EmilGorm
EmilGorm marked this pull request as ready for review October 22, 2026 21:55
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for aa46acd at 2026-10-23 00:01:

No log files found

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for aa46acd at 2026-10-23 00:04:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 3 errors and 10 warnings.'
Found 3 errors and 10 warnings.
++ [[ 3 -gt 0 ]]
++ cat /sw/BUILD/6d37392d9ff66077d20b015e40d9ae3e77bedb67/O2Physics-code-check/errors.txt
PWGCF/GenericFramework/Core/FlowPtContainer.cxx:57:56: error: using decl 'PtMomentGroup' is unused [misc-unused-using-decls,-warnings-as-errors]
PWGCF/GenericFramework/Core/FlowPtContainer.cxx:70:46: error: no header providing "std::errc" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/GenericFramework/Core/FlowPtContainer.cxx:275:3: error: no header providing "GFW" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 10 -gt 0 ]]
++ cat /sw/BUILD/6d37392d9ff66077d20b015e40d9ae3e77bedb67/O2Physics-code-check/warnings.txt
PWGCF/GenericFramework/Core/FlowPtContainer.cxx:82:27: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
PWGCF/GenericFramework/Core/FlowPtContainer.cxx:135:18: warning: implicit conversion 'std::uint64_t' (aka 'unsigned long') -> 'bool' [readability-implicit-bool-conversion]
PWGCF/GenericFramework/Core/FlowPtContainer.cxx:140:9: warning: implicit conversion 'std::uint64_t' (aka 'unsigned long') -> 'bool' [readability-implicit-bool-conversion]
PWGCF/GenericFramework/Core/FlowPtContainer.cxx:277:93: warning: implicit conversion 'value_type' (aka 'int') -> 'bool' [readability-implicit-bool-conversion]
PWGCF/GenericFramework/Core/FlowPtContainer.cxx:426:24: warning: use designated initializer list to initialize 'PtCorrConfig' [modernize-use-designated-initializers]
PWGCF/GenericFramework/Core/FlowPtContainer.cxx:505:34: warning: use designated initializer list to initialize 'PtMomentConfig' [modernize-use-designated-initializers]
PWGCF/GenericFramework/Core/FlowPtContainer.cxx:1095:34: warning: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr]
PWGCF/GenericFramework/Core/FlowPtContainer.cxx:1096:10: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
PWGCF/GenericFramework/Core/FlowPtContainer.cxx:1256:32: warning: implicit conversion 'std::uint64_t' (aka 'unsigned long') -> 'bool' [readability-implicit-bool-conversion]
PWGCF/GenericFramework/Core/FlowPtContainer.h:287:3: warning: function 'getPtMoment' should be marked [[nodiscard]] [modernize-use-nodiscard]
++ [[ 3 -gt 0 ]]
++ exit 1
--

Full log here.

@EmilGorm
EmilGorm enabled auto-merge (squash) October 23, 2026 06:11

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @EmilGorm.

@EmilGorm
EmilGorm merged commit be2cc33 into AliceO2Group:master Oct 23, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants