Repository navigation
[PWGEM] PhotonMeson: Add signal loss task for mesons - #18408
Merged
Merged
Conversation
jokonig
commented
Oct 22, 2026
jokonig
commented
Collaborator
- First version of a signal loss task implemented taking into account the various event selection flags
- First version of a multiplicity dependent estimate (still to be improved)
- Event selection flags moved from event normalization task to the event tables to allow multiple tasks to access this information
|
O2 linter results: ❌ 0 errors, |
github-actions
Bot
added
pwgem
datamodel
photon
- First version of a signal loss task implemented taking into account the various event selection flags - First version of a multiplicity dependent estimate (still to be improved) - Event selection flags moved from event normalization task to the event tables to allow multiple tasks to access this information
jokonig
marked this pull request as ready for review
October 22, 2026 13:06
jokonig
requested review from
alibuild,
amaringarcia,
dsekihat,
hscheid,
mhemmer-cern and
reygers
as code owners
October 22, 2026 13:06
mhemmer-cern
left a comment
mhemmer-cern
left a comment
Collaborator
There was a problem hiding this comment.
Looks good except some comments from my side.
mhemmer-cern
approved these changes
Oct 22, 2026
mhemmer-cern
left a comment
mhemmer-cern
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me now :)
Collaborator
|
macOS-arm failing due to a Git(Hub) issue... |
Collaborator
Collaborator
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.