Skip to content

[ALICE3] Add root files for LUTs - #18406

Merged
njacazio merged 4 commits into
AliceO2Group:masterfrom
njacazio:nj-acts-luts
Oct 22, 2026
Merged

njacazio merged 4 commits into
AliceO2Group:masterfrom
njacazio:nj-acts-luts

Conversation

@njacazio

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 18 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title Add root files for LUTs [ALICE3] Add root files for LUTs Oct 22, 2026
@njacazio
njacazio marked this pull request as ready for review October 22, 2026 11:30
@njacazio
njacazio enabled auto-merge (squash) October 22, 2026 11:34

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @njacazio.

@njacazio
njacazio merged commit 59933dc into AliceO2Group:master Oct 22, 2026
14 of 15 checks passed
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 9b77c54 at 2026-10-22 13:45:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 6 errors and 11 warnings.'
Found 6 errors and 11 warnings.
++ [[ 6 -gt 0 ]]
++ cat /sw/BUILD/b1c29a56c5b44dc8536f01deeffda9a45be03f6b/O2Physics-code-check/errors.txt
ALICE3/Core/FlatLutRootWriter.cxx:24:44: error: no header providing "o2::fastsim::lutHeader_t" is directly included [misc-include-cleaner,-warnings-as-errors]
ALICE3/Core/FlatLutRootWriter.cxx:30:38: error: no header providing "std::size_t" is directly included [misc-include-cleaner,-warnings-as-errors]
ALICE3/Core/FlatLutRootWriter.cxx:40:40: error: no header providing "o2::fastsim::lutEntry_t" is directly included [misc-include-cleaner,-warnings-as-errors]
ALICE3/Core/FlatLutRootWriter.cxx:64:19: error: std::move of the variable 'row' of the trivially-copyable type 'FlatLutRootRow' has no effect [performance-move-const-arg,-warnings-as-errors]
ALICE3/Core/FlatLutRootWriter.cxx:148:14: error: no header providing "o2::fastsim::kNumCovarianceTerms" is directly included [misc-include-cleaner,-warnings-as-errors]
ALICE3/Core/FlatLutRootWriter.cxx:149:16: error: no header providing "o2::fastsim::kNumEigenModes" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 11 -gt 0 ]]
++ cat /sw/BUILD/b1c29a56c5b44dc8536f01deeffda9a45be03f6b/O2Physics-code-check/warnings.txt
ALICE3/Core/FlatLutRootWriter.cxx:148:3: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
ALICE3/Core/FlatLutRootWriter.cxx:149:3: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
ALICE3/Core/FlatLutRootWriter.cxx:150:3: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
ALICE3/Core/FlatLutRootWriter.cxx:151:3: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
ALICE3/Core/FlatLutRootWriter.cxx:169:28: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
ALICE3/Core/FlatLutRootWriter.cxx:170:30: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
ALICE3/Core/FlatLutRootWriter.cxx:171:30: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
ALICE3/Core/FlatLutRootWriter.cxx:172:30: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
ALICE3/Core/FlatLutRootWriter.cxx:191:49: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
ALICE3/Core/FlatLutRootWriter.cxx:192:53: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
ALICE3/Core/FlatLutRootWriter.h:61:3: warning: function 'writeToFile' should be marked [[nodiscard]] [modernize-use-nodiscard]
++ [[ 6 -gt 0 ]]
++ exit 1
--

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants