Skip to content

Fix EoS report browser tests failing right after a shift change - #2297

Merged
graduta merged 2 commits into
mainfrom
fix/test-failure-of-EOS-report-due-to-bad-time
Oct 26, 2026
Merged

graduta merged 2 commits into
mainfrom
fix/test-failure-of-EOS-report-due-to-bad-time

Conversation

@graduta

@graduta graduta commented Oct 26, 2026 •

Copy link
Copy Markdown
Member

I DON'T have JIRA ticket

  • explain what this PR does
  • if it is a new feature, explain how you plan to use it
  • tests are added
  • documentation was updated or added

The ECS, QC/PDP and Shift Leader EoS report browser tests failed during the 30 minutes following each shift change (Europe/Zurich 07:00-07:30, 15:00-15:30, 23:00-23:30). In that window the pending shift is the previous one, but the tests built their fixtures from the current time. The fixtures (previous report, run trigger times, environment history timestamp) are now derived from the pending shift returned by ShiftService.

Notable changes for users:

  • None

Notable changes for developers:

  • EoS report browser tests no longer depend on the time of day

Changes made to the database:

  • None

@graduta
graduta requested a review from isaachilly as a code owner October 26, 2026 14:37
@graduta graduta added the test Label to be used when PR is only about tests label Oct 26, 2026
@graduta graduta self-assigned this Oct 26, 2026
@codecov

codecov Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.94%. Comparing base (2157bd9) to head (641bd8c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2297   +/-   ##
=======================================
  Coverage   45.94%   45.94%           
=======================================
  Files        1067     1067           
  Lines       17589    17589           
  Branches     3252     3252           
=======================================
  Hits         8082     8082           
  Misses       9507     9507           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@graduta
graduta merged commit 947277a into main Oct 26, 2026
26 checks passed
@graduta
graduta deleted the fix/test-failure-of-EOS-report-due-to-bad-time branch October 26, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Label to be used when PR is only about tests

Development

Successfully merging this pull request may close these issues.

1 participant