Repository navigation
Fix EoS report browser tests failing right after a shift change - #2297
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2297 +/- ##
=======================================
Coverage 45.94% 45.94%
=======================================
Files 1067 1067
Lines 17589 17589
Branches 3252 3252
=======================================
Hits 8082 8082
Misses 9507 9507 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I DON'T have JIRA ticket
The ECS, QC/PDP and Shift Leader EoS report browser tests failed during the 30 minutes following each shift change (Europe/Zurich 07:00-07:30, 15:00-15:30, 23:00-23:30). In that window the pending shift is the previous one, but the tests built their fixtures from the current time. The fixtures (previous report, run trigger times, environment history timestamp) are now derived from the pending shift returned by
ShiftService.Notable changes for users:
Notable changes for developers:
Changes made to the database: