Skip to content

[O2B-1636] Fix flaky filters reset in browser tests - #2292

Merged
graduta merged 2 commits into
mainfrom
fix/O2B-1641/flaky-reset-filters
Oct 23, 2026
Merged

graduta merged 2 commits into
mainfrom
fix/O2B-1641/flaky-reset-filters

Conversation

@graduta

@graduta graduta commented Oct 23, 2026 •

Copy link
Copy Markdown
Member

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • None, only the browser tests are changed.

Notable changes for developers:

  • The resetFilters helper of the browser tests returned as soon as no loading row was displayed. This is already true right after the click on "Reset all filters", because the previous table (e.g. an empty one) is still displayed while the reload starts asynchronously. The following waitForTableLength then had to cover the whole reload within the 1.5s default timeout, which made the log overview filters beforeEach hook fail on the CI with Expected table of length 10, but got 0.
  • resetFilters now remembers the table content and the state of the reset button before the click, and, if some filter was active, waits for the table content to change (up to 1.5s) before waiting for the loading to end.
  • The root cause of the flakiness was not reproduced locally: this makes the helper wait for the reload it triggers, but if the failure persists on the CI, the reset click or the response may be what is lost.
  • Not run locally.

Changes made to the database:

  • None

…browser tests

resetFilters returned as soon as no loading row was displayed, which is already true right after the click since the previous table is still displayed. The following wait for the table length then had to cover the whole reload within the 1.5s default timeout, making the log overview filters hooks flaky on the CI.
@graduta
graduta requested a review from isaachilly as a code owner October 23, 2026 13:47
@graduta graduta added bug Something isn't working test Label to be used when PR is only about tests labels Oct 23, 2026
@graduta graduta self-assigned this Oct 23, 2026
@codecov

codecov Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.17%. Comparing base (ae88437) to head (f5b9e05).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2292   +/-   ##
=======================================
  Coverage   46.17%   46.17%           
=======================================
  Files        1059     1059           
  Lines       17494    17494           
  Branches     3210     3210           
=======================================
  Hits         8078     8078           
  Misses       9416     9416           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@graduta graduta changed the title [O2B-1641] Fix flaky filters reset in browser tests [O2B-1636] Fix flaky filters reset in browser tests Oct 23, 2026
@graduta
graduta merged commit 3338aa2 into main Oct 23, 2026
26 checks passed
@graduta
graduta deleted the fix/O2B-1641/flaky-reset-filters branch October 23, 2026 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working test Label to be used when PR is only about tests

Development

Successfully merging this pull request may close these issues.

1 participant