Repository navigation
[O2B-1636] Fix flaky filters reset in browser tests - #2292
Merged
Merged
Conversation
…browser tests resetFilters returned as soon as no loading row was displayed, which is already true right after the click since the previous table is still displayed. The following wait for the table length then had to cover the whole reload within the 1.5s default timeout, making the log overview filters hooks flaky on the CI.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2292 +/- ##
=======================================
Coverage 46.17% 46.17%
=======================================
Files 1059 1059
Lines 17494 17494
Branches 3210 3210
=======================================
Hits 8078 8078
Misses 9416 9416 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a JIRA ticket
Notable changes for users:
Notable changes for developers:
resetFiltershelper of the browser tests returned as soon as no loading row was displayed. This is already true right after the click on "Reset all filters", because the previous table (e.g. an empty one) is still displayed while the reload starts asynchronously. The followingwaitForTableLengththen had to cover the whole reload within the 1.5s default timeout, which made the log overview filtersbeforeEachhook fail on the CI withExpected table of length 10, but got 0.resetFiltersnow remembers the table content and the state of the reset button before the click, and, if some filter was active, waits for the table content to change (up to 1.5s) before waiting for the loading to end.Changes made to the database: