Repository navigation
[O2B-1638] Adapt the filters button, the filters panel and the header of the overview pages to phones and tablets - #2287
Merged
Conversation
… of the overview pages to phones and tablets On tablets and phones the filters panel is displayed on the whole width of the screen and, on phones, each filter label is displayed above its input. On phones the header of the overview pages wraps on several lines instead of squeezing and clipping its buttons. The filters buttons, the panel and the header use a smaller font. They are shared by every overview page using the filters panel component or the header-container class.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2287 +/- ##
=======================================
Coverage 46.31% 46.31%
=======================================
Files 1056 1056
Lines 17440 17440
Branches 3183 3183
=======================================
Hits 8078 8078
Misses 9362 9362 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…utton and keep tables from widening the page on phones and tablets Seven of the thirteen pages using the filters panel do not use the header-container class for their header, so the header rules are also applied to the row directly containing the filters button group, whatever its classes, and to the flex rows nested in it. A table wider than the screen now scrolls inside its own box instead of widening the layout viewport, in which the fixed filters panel is positioned and was displayed partly out of the screen.
4 tasks done
… the environments overview test In the test displaying the dropdown links, the popover of the second environment was opened with a real mouse click while the popover of the first one was still opened. Depending on the layout, the click landed on one of its external links, opening a new tab: the page of the test then stopped rendering, and the next click of the suite (opening the filters panel) hung until the protocol timeout. The second popover is now opened with a javascript click, as the first one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a JIRA ticket
Notable changes for users:
Notable changes for developers:
filtersPanelPopovercomponent and in the header: theheader-containerclass, and any row directly containing the filters button group (.flex-row:has(> .filters-toolbar)), as seven of the thirteen pages do not useheader-container. So every page using them benefits (log overview, runs overview and runs per period, data pass or simulation pass, LHC fills, environments, LHC periods, simulation passes, data passes and QC flag types overviews). No page-specific code is needed.filtersPanelPopoverhas new class names:filters-toolbaron the filters button group,filters-panelon the panel content (replacingw-l),filter-row,filter-labelandfilter-inputon each filter, andfilters-popoveras the popover class. The sheet layout overrides the position computed by the popover in javascript with!importantin a media query.table.table(except the log overview one, which has its own scroll wrapper) is displayed as a block scrolling horizontally. Otherwise a table wider than the screen widens the layout viewport of the phone, and the filters panel, which is fixed and positioned against it, is displayed partly out of the screen.Changes made to the database:
🤖 Generated with Claude Code