Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature/O2B-1623/docs-attachments-endpoints #2282 +/- ##
===============================================================================
+ Coverage 42.53% 43.11% +0.57%
===============================================================================
Files 1064 1071 +7
Lines 17453 17496 +43
Branches 3178 3176 -2
===============================================================================
+ Hits 7424 7543 +119
+ Misses 10029 9953 -76 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
graduta
added this pull request to stack #2276
October 22, 2026 14:02
The controller disabled the JSDoc rules for the whole file: its four handlers now describe their parameters and their result (and the documentation of the hosts handler, which read "the hosts that on which", is fixed).
…er entity ids The run number, the detector id, the process id and the host id of the DPL process endpoints were validated as any number (`0`, negative numbers and decimals were accepted and ended as a 404). They are validated with `EntityIdDto`, so that invalid values are rejected with a 400, and an API test checks one invalid value on each endpoint.
…processes, hosts and executions Nothing uses the creation and update dates returned by the DPL process endpoints: the run details page only reads the names, the process type label, the host name and the arguments, and no test checks them. The adapters of the DPL detectors, processes, process types, process executions and hosts, only used by these endpoints (and the gRPC creation of an execution, whose response is only the id), stop returning them and their typedefs are updated. The (always empty) relations of these entities are left as they are, as the tests check them.
…ions The four read methods of `DplProcessService` queried the DPL detectors, DPL processes, hosts and process executions repositories directly, while the creation of an execution already relies on small functions. They now use `getDplDetectorIdsWithExecutedProcessesInRun`, `getAllDplDetectors`, `getDplProcessIdsExecutedInRunByDetector`, `getAllDplProcesses`, `getHostIdsWithExecutedDplProcess`, `getAllHosts` and `getAllDplProcessExecutions`, each with a test. The two steps of the queries (a first one for the ids, a second one for the sorted entities) are kept as they were. Checked against the previous service with the SQL layer stubbed: the same queries are generated (up to redundant parentheses around conditions) and the same results are returned.
`processId` and `hostId` are integers (as the columns of the table) and `args` can be null, but the typedef declared strings.
graduta
force-pushed
the
feature/O2B-1623/docs-dpl-process-endpoints
branch
from
October 22, 2026 14:35
43d3189 to
defc87e
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a JIRA ticket
Part of a stack of PRs documenting the HTTP API (O2B-1623). This PR is stacked on the previous one of the stack (its base is the branch of that PR): GitHub retargets it to
mainonce the PRs below are merged.Notable changes for users:
GET /api/dpl-process/*endpoints (detectors,processes,hosts,executions) are now documented at/api-docs.0, negative numbers and decimals are rejected with a 400 instead of ending as a 404.createdAtandupdatedAt(nothing used them; breaking for any external client reading them).Notable changes for developers:
DplProcessServicequeried the repositories directly while the creation of an execution already relies on small functions: they now usegetDplDetectorIdsWithExecutedProcessesInRun,getAllDplDetectors,getDplProcessIdsExecutedInRunByDetector,getAllDplProcesses,getHostIdsWithExecutedDplProcess,getAllHostsandgetAllDplProcessExecutions, each with a test. The two steps of the queries (ids first, then sorted entities) are kept. Checked against the previous service with the SQL layer stubbed: same queries (up to redundant parentheses) and same results.createdAt/updatedAt, and their typedefs are updated. The always empty relations (processesExecutions, anddetector,host,process,runset tonull) are left as they are: the tests check them.DplProcessExecutiontypedef declared strings forprocessIdandhostId(integers) and forargs(nullable).Changes made to the database:
🤖 Generated with Claude Code