Repository navigation
Conversation
The handler disabled a JSDoc rule instead of describing its parameters and its result, and the API test of the endpoint was titled `GET /api/eos-report` whereas the endpoint is a `POST`.
… report fails The handler of `POST /api/eos-report` had no error handling, unlike the other controllers: an error of the services (for example the current user not being found) was not sent as such and ended as a generic server error. Errors are now converted with `updateExpressResponseFromNativeError` (a missing user gives a 404 for example). API tests check the validation errors of an unknown report type, of a missing type specific part and of a start of shift given in the body.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/O2B-1623/docs-gaq-detectors-endpoints #2280 +/- ##
=================================================================================
+ Coverage 46.61% 46.65% +0.04%
=================================================================================
Files 1063 1063
Lines 17435 17439 +4
Branches 3176 3176
=================================================================================
+ Hits 8127 8136 +9
+ Misses 9308 9303 -5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
graduta
added this pull request to stack #2276
October 22, 2026 14:02
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a JIRA ticket
Part of a stack of PRs documenting the HTTP API (O2B-1623). This PR is stacked on the previous one of the stack (its base is the branch of that PR): GitHub retargets it to
mainonce the PRs below are merged.Notable changes for users:
POST /api/eos-reportendpoint is now documented at/api-docs(flaggedx-llm-exclude, as it creates a log entry).Notable changes for developers:
logService), and the endpoint returns the log it creates, so there is no entity of its own to removecreatedAt/updatedAtfrom.updateExpressResponseFromNativeError(separate commit, easy to drop if not wanted), with API tests for the validation errors (unknown report type, missing type specific part, start of shift given in the body).GET /api/eos-reportwhereas the endpoint is aPOST: fixed.Changes made to the database:
🤖 Generated with Claude Code