Repository navigation
Make audit-pr findings cite the full path and line number - #617
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Unresolved location-validation rules can discard deletion-only regressions and require invented line numbers for structural findings that have no line-level anchor.
2 open issues
What changed in this PR
This PR updates the repository’s audit-pr tooling to require repository-relative paths and verified line numbers, addressing ambiguous or missing locations following #588.
Changes:
- Aligns location rules across the prompt, skill, finding template, examples, and refuter.
- Adds location verification and shortens prompt passages to fit the character budget.
- Updates runtime and development dependencies, including Firebase’s major version.
| File | Description |
|---|---|
| package.json | Updates runtime and development dependency ranges. |
| package-lock.json | Records updated dependencies and transitive resolutions. |
| .github/prompts/audit-pr.prompt.md | Requires verified locations and condenses refutation instructions. |
| .claude/skills/audit-pr/SKILL.md | Adds matching location and verification rules. |
| .claude/skills/audit-pr/assets/review-summary.template.md | Updates finding fields, examples, and location checks. |
| .claude/skills/audit-pr/agents/finding-refuter.md | Verifies cited paths and line numbers during refutation. |
Review effort: Balanced
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

audit-prfindings now give their location as the file's path from the repository root plus the line number of the quoted line, for examplesrc/features/billing/index.ts:42.#588 removed the line range from the finding's
Filefield and added the rule "No line number you did not read." Reviews then omitted line numbers. Nothing required a full path either, so a finding could cite onlyindex.tsin a repository holding dozens of files with that name.The line number is read from the file, never estimated. The refutation pass now checks that the number holds the quoted line, corrects a wrong number, and drops a finding whose line is not found.
The prompt file and the skill carry the same rule. The skill's finding template, worked examples, and finding-refuter agent follow it.
PR also includes the following changes:
brag.mp4