Skip to content

Make audit-pr findings cite the full path and line number - #617

Merged
AlexJSully merged 3 commits into
mainfrom
ajs-261105-fix-audit-pr-line
Nov 5, 2026
Merged

AlexJSully merged 3 commits into
mainfrom
ajs-261105-fix-audit-pr-line

Conversation

@AlexJSully

Copy link
Copy Markdown
Owner

audit-pr findings now give their location as the file's path from the repository root plus the line number of the quoted line, for example src/features/billing/index.ts:42.

#588 removed the line range from the finding's File field and added the rule "No line number you did not read." Reviews then omitted line numbers. Nothing required a full path either, so a finding could cite only index.ts in a repository holding dozens of files with that name.

The line number is read from the file, never estimated. The refutation pass now checks that the number holds the quoted line, corrects a wrong number, and drops a finding whose line is not found.

The prompt file and the skill carry the same rule. The skill's finding template, worked examples, and finding-refuter agent follow it.

PR also includes the following changes:

  • The prompt shortens four passages in its refutation pass, three that restated rules from other sections and one that stated no rule, to stay within its 52,000-character budget.
brag.mp4

@AlexJSully
AlexJSully requested a balanced review from Copilot November 5, 2026 19:34
@AlexJSully AlexJSully self-assigned this Nov 5, 2026
@vercel

vercel Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
portfolio Ready Ready Preview Nov 5, 2026 9:16pm UTC

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Unresolved location-validation rules can discard deletion-only regressions and require invented line numbers for structural findings that have no line-level anchor.

2 open issues
What changed in this PR

This PR updates the repository’s audit-pr tooling to require repository-relative paths and verified line numbers, addressing ambiguous or missing locations following #588.

Changes:

  • Aligns location rules across the prompt, skill, finding template, examples, and refuter.
  • Adds location verification and shortens prompt passages to fit the character budget.
  • Updates runtime and development dependencies, including Firebase’s major version.
File Description
package.json Updates runtime and development dependency ranges.
package-lock.json Records updated dependencies and transitive resolutions.
.github/​prompts/​audit-pr.prompt.md Requires verified locations and condenses refutation instructions.
.claude/​skills/​audit-pr/​SKILL.md Adds matching location and verification rules.
.claude/​skills/​audit-pr/​assets/​review-summary.template.md Updates finding fields, examples, and location checks.
.claude/​skills/​audit-pr/​agents/​finding-refuter.md Verifies cited paths and line numbers during refutation.

Review effort: Balanced

Comment thread .github/prompts/audit-pr.prompt.md Resolved
@AlexJSully
AlexJSully merged commit c114902 into main Nov 5, 2026
8 checks passed
@AlexJSully
AlexJSully deleted the ajs-261105-fix-audit-pr-line branch November 5, 2026 21:16

This branch was successfully deployed

1 active deployment
Preview — 5264b326 Deployed Nov 5, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants