Skip to content

fix: reject mixed diseases in the legacy alert adapter #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BaruqueRodrigues wants to merge 2 commits into
base: codex/pr5-canonical-inputs
Choose a base branch
from
Open

fix: reject mixed diseases in the legacy alert adapter #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e8b911
fix: reject mixed diseases at the legacy adapter boundary
Oct 29, 2026
b453e84
style: normalize validation EOF whitespace without changing expressions
Oct 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions R/alert_functions.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,6 +349,14 @@ pipe_infodengue <- function(cities, cid10="A90", datarelatorio, finalday = NULL,

.as_legacy_alert_objects <- function(result) {
data <- result$data
diseases <- unique(c(as.character(data$CID10),
as.character(result$parameters$cid10)))
if (!"CID10" %in% names(data) ||
!"cid10" %in% names(result$parameters) ||
length(diseases) != 1L || anyNA(diseases) || any(!nzchar(diseases))) {
stop("The legacy adapter requires exactly one disease in data and parameters.",
call. = FALSE)
}
groups <- split(seq_len(nrow(data)), factor(data$cidade,
levels = unique(data$cidade)))
legacy <- lapply(names(groups), function(city) {
Expand Down
10 changes: 10 additions & 0 deletions tests/testthat/test-legacy-disease-guard.R
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
test_that("legacy adapter rejects mixed or inconsistent disease results", {
result <- review_result()
mixed <- result
mixed$data$CID10[1] <- "A92.0"
expect_error(AlertTools:::.as_legacy_alert_objects(mixed), "exactly one disease")
inconsistent <- result
inconsistent$parameters$cid10 <- "A92.0"
expect_error(AlertTools:::.as_legacy_alert_objects(inconsistent), "exactly one disease")
expect_s3_class(AlertTools:::.as_legacy_alert_objects(result)[[1]], "alerta")
})
Loading