Repository navigation
Conversation
Alchemy 8.4.2 deprecates the position of menu entries, and register_module is deprecated already, so the users entry now gets inserted at index 4 to keep it between Languages and Sites. Only Alchemy 8.4.2 lists entries inserted without a position in place, hence the raised minimum version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
alchemy_cms 8.4.2 deprecates the
positionof menu entries (AlchemyCMS/alchemy_cms#4435) ahead of its removal in 9.0 (AlchemyCMS/alchemy_cms#4434).register_moduleis deprecated already, so the users entry is now inserted withAlchemy.config.menu.insert(4, ...), which keeps it between Languages and Sites. This is the 8.4 counterpart of the same change to the devise directory in alchemy_cms main.Only alchemy_cms 8.4.2 lists entries inserted without a position in place. On earlier versions the users entry would end up at the bottom of the navigation, so the minimum
alchemy_cmsversion goes up to 8.4.2. This can only be merged once that version is released; until then the CI jobs against the8.4-stablebranch of alchemy_cms can't resolve the dependency.