Repository navigation
AG-43979 Fix max-length default claim and note title in HTML filtering docs - #949
Merged
Merged
Conversation
…g docs Follow-up to #927 addressing the review comments left by @maximtop: - Remove the "Default value" paragraph of the `max-length` special attribute: neither CoreLibs nor the extension applies a default max-length, and the paragraph contradicted the `[tag-content]` -> `:contains()` conversion table, which adds no length constraint. - Drop the redundant "Note" title from the `:contains()` synonyms admonition, so it uses a plain `:::note` like the one above.
|
Preview was deployed to: https://pull-request-949.kb-adg.pages.dev/ |
slvvko
changed the title
slvvko
marked this pull request as ready for review
October 16, 2026 19:56
SeverAnna
approved these changes
Oct 18, 2026
maximtop
approved these changes
Oct 19, 2026
maximtop
left a comment
maximtop
left a comment
Contributor
There was a problem hiding this comment.
A couple of nits nearby, outside the diff:
min-lengthexample: "exceeds400characters" — the rule also matches exactly 400. Should be "is at least400characters".- 65535 note: the extension still converts
[min-length]/[max-length]above 65535 to:contains(), JS regexps have no such limit. So "no:contains()equivalent" holds only for CoreLibs-based apps, worth saying so.
|
Preview was deployed to: https://pull-request-949.kb-adg.pages.dev/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to #927 (Document raw-text
:contains()arguments of HTML filtering rules), addressing the two review comments left by @maximtop after that PR was merged ("A few nits inline, can go into a follow-up").docs/general/ad-filtering/create-own-filters.mdmax-length: removed the Default value paragraph ("If this parameter is not specified, themax-lengthis considered to be 8192.").:contains(): dropped the redundant "Note" title, now a plain:::notelike the one above.Why
The
max-lengthparagraph stated a default that neither CoreLibs nor the extension has, and it contradicted the[tag-content]→:contains()conversion table right above it:$$div[tag-content="banner"]converts to$$div:contains(banner)with no length constraint, and the agtree converter emits a length regexp only when[max-length]is present. No user-visible rule syntax changes — the text simply no longer claims a default.The
:::note Notetitle carried no information, so it was dropped to match the untitled:::noteused earlier in the same article.Verification
npx markdownlint-cli2 docs/general/ad-filtering/create-own-filters.md— 0 errors.grep -rn "8192" docs/— no occurrences left.Notes
tsurlfilter'spackages/agtree/src/converter/cosmetic/html.tsstill has a code comment claiming the same 8192 default (line 56 onmaster); it should be corrected there separately.