Repository navigation
fix(deps): take the xunit.v3 family at 4.0.2 and FluentValidation 12.2.0, in place of #189 - #192
Merged
Merged
Conversation
The xunit.v3 packages require one another at exactly one version: xunit.v3.mtp-v2 4.0.1 asks for xunit.v3.assert = 4.0.1. Dependabot's grouped #189 moved xunit.v3.assert and xunit.v3.extensibility.core to 4.0.2 but left the xunit.v3 metapackage on 4.0.1, so the restore failed with NU1608. This moves the whole family, xunit.v3 too, and the compatibility island's own xunit.v3 pin, which the contract kit's 4.0.2 floor would otherwise conflict with. xunit.v3.assert and xunit.v3.extensibility.core ship as the contract kit's dependencies, hence fix(deps). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0164hf4jJ3KsP3tyC3Uoa55L
The minor Dependabot proposed in #189, beside the xunit family that kept that pull request from restoring. FluentValidation ships as the FluentValidation package's dependency, hence fix(deps). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0164hf4jJ3KsP3tyC3Uoa55L
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
#189, Dependabot's grouped update, fails its restore with NU1608.
xunit.v3.assertandxunit.v3.extensibility.coreto 4.0.2 but leaves thexunit.v3metapackage on 4.0.1, andxunit.v3.mtp-v24.0.1 requiresxunit.v3.assert= 4.0.1.xunit.runner.visualstudioat 4.0.1, including the compatibility island's ownxunit.v3pin, which would otherwise conflict with the contract kit's new floor. FluentValidation 12.2.0, the other shipped update of fix(deps): Bump the dotnet group with 10 updates #189, is in a commit of its own.fix(deps):xunit.v3.assert,xunit.v3.extensibility.coreandFluentValidationare shipped dependencies, so the next release is a patch.mainthrough chore(deps): Bump Microsoft.Testing.Extensions.CodeCoverage and 5 others #177.Checklist
dotnet test --project tests/AdCodicem.ValueObjects.UnitTestspasses (7,324 tests, 143 skipped) anddotnet test --project tests/AdCodicem.ValueObjects.GeneratorTestspasses (1,339). Both run locally on SDK 10.0.402 afterdotnet restore AdCodicem.ValueObjects.slnxand a Release build with no warnings. The unit suite was run again after the FluentValidation bump.Generated by Claude Code