Repository navigation
Accept advisory down-mix mode updates without a consumer as a NO-OP - #59
Merged
Merged
Conversation
jingbo-marquis
commented
Oct 15, 2026
jingbo-marquis
commented
Contributor
- Classify ck_metadata_iamf_downmix_mode as advisory: accept-and-ignore with a rate-limited warning when the rendering path has no consumer
- Validate down-mix mode values at update time (-EINVAL); keep critical metadata and unknown element ids failing
- Document the advisory contract in oar.h; add test_downmix_mode_metadata
- Classify ck_metadata_iamf_downmix_mode as advisory: accept-and-ignore with a rate-limited warning when the rendering path has no consumer - Validate down-mix mode values at update time (-EINVAL); keep critical metadata and unknown element ids failing - Document the advisory contract in oar.h; add test_downmix_mode_metadata Signed-off-by: Jingbo Hou <jingbo.hou@samsung.com>
jingbo-marquis
requested review from
sunghee-hwang,
trevorknight,
trsonic,
yeroro,
yilun-zhangs and
yongmin-kwon
October 15, 2026 08:44
yilun-zhangs
approved these changes
Oct 15, 2026
yeroro
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.