Repository navigation
Conversation
Adds extra synchronisation delay to ensure that all above blocks which are valid targets for global intrabc are already available when the current block encode runs. Fixes AOMediaCodec#5571.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds extra synchronisation delay to ensure that all above blocks which are valid targets for global intrabc are already available when the current block encode runs.
Fixes #5571.
This can decrease speed noticeably on row-mt intra-only encodes with global intrabc enabled as row threads don't parallelise as well (modes not using it, including inter frames, are not affected).
I think the current proposal is the best solution, though there are alternatives with different tradeoffs: