Repository navigation
Exclude sh_from_leading from the sequence header consistency check - #5568
Open
xinzhao-apple wants to merge 1 commit into
Open
xinzhao-apple wants to merge 1 commit into
xinzhao-apple wants to merge 1 commit into
Conversation
are_seq_headers_consistent() memcmp()s SequenceHeader up to op_params, which includes sh_from_leading, a decoder-side flag that is not part of the sequence header syntax. When the active sequence header is re-sent bit-identically in a leading temporal unit, the stored copy is tagged sh_from_leading = 1 while the active one has 0, so the next leading tile group fails with "Sequence Header changed at OBU_LEADING_TILE_GROUP" even though the spec allows bit-identical redundant copies. Skip the flag in the comparison.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
are_seq_headers_consistent() memcmp()s SequenceHeader up to op_params, which includes sh_from_leading, a decoder-side flag that is not part of the sequence header syntax. When the active sequence header is re-sent bit-identically in a leading temporal unit, the stored copy is tagged sh_from_leading = 1 while the active one has 0, so the next leading tile group fails with "Sequence Header changed at OBU_LEADING_TILE_GROUP" even though the spec allows bit-identical redundant copies. Skip the flag in the comparison.
No spec change is needed, this aligns the AVM decoder with the AV2 spec.