Repository navigation
Conversation
edcote
commented
Oct 16, 2026
Contributor
- Multiplying the quantized coefficient magnitude by the dequantizer step in 32-bit signed arithmetic before passing the product to the 64-bit rounding macro can overflow signed 32-bit integers.
- Casting the quantized coefficient magnitude to the 64-bit intermediate transform type before multiplication prevents signed integer overflow and matches the floating-point and trellis quantizer paths.
- Multiplying the quantized coefficient magnitude by the dequantizer step in 32-bit signed arithmetic before passing the product to the 64-bit rounding macro can overflow signed 32-bit integers. - Casting the quantized coefficient magnitude to the 64-bit intermediate transform type before multiplication prevents signed integer overflow and matches the floating-point and trellis quantizer paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.