Skip to content

Fix mi step - #5564

Merged
urvangjoshi merged 1 commit into
AOMediaCodec:av2-encfrom
chengchen-google:s14-2
Oct 16, 2026
Merged

urvangjoshi merged 1 commit into
AOMediaCodec:av2-encfrom
chengchen-google:s14-2

Conversation

@chengchen-google

Copy link
Copy Markdown
Contributor

Should be mi_size_high[bsize].

Should be mi_size_high[bsize].

Change-Id: Iaa1a40af886356fc19a0c7cba7c4c0d2f91028f0

@urvangjoshi urvangjoshi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it will have no effect as the code was executed for is_square_block(bsize) condition , can you confirm?
But agreed that it's good to fix it still.

@chengchen-google

Copy link
Copy Markdown
Contributor Author

Just noise level impact. +/- 0.01% difference

@urvangjoshi

Copy link
Copy Markdown
Contributor

I believe it will have no effect as the code was executed for is_square_block(bsize) condition , can you confirm? But agreed that it's good to fix it still.

Oops, I misread the fix initially assuming it was a width --> height fix, but the fix is block_size_high --> mi_size_high. So, noise-level stat change makes sense.

@urvangjoshi
urvangjoshi merged commit 58aa76d into AOMediaCodec:av2-enc Oct 16, 2026
107 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants