Repository navigation
Fix mi step - #5564
Merged
Merged
Fix mi step#5564
Conversation
Should be mi_size_high[bsize]. Change-Id: Iaa1a40af886356fc19a0c7cba7c4c0d2f91028f0
urvangjoshi
approved these changes
Oct 16, 2026
urvangjoshi
left a comment
Contributor
There was a problem hiding this comment.
I believe it will have no effect as the code was executed for is_square_block(bsize) condition , can you confirm?
But agreed that it's good to fix it still.
Contributor
Author
|
Just noise level impact. +/- 0.01% difference |
Contributor
Oops, I misread the fix initially assuming it was a width --> height fix, but the fix is block_size_high --> mi_size_high. So, noise-level stat change makes sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should be mi_size_high[bsize].