[edoyango]

As a follow up to #197 This adds undo functionality to the AlignDataVariableDimensionsToDatasetCoords class. By default, undoing the dim alignment is turned off (restoring previous behaviour). Turn it on by passing undo=True at instantiation.

Associated tests have been added and made use of parameterized tests to make existing tests a bit neater.

[coveralls]

Pull Request Test Coverage Report for Build 19249517778

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 24 of 24 (100.0%) changed or added relevant lines in 2 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.02%) to 61.189%

---

Totals
Change from base Build 19207266644:	0.02%
Covered Lines:	9552
Relevant Lines:	15196

---

💛 - Coveralls

[tennlee]

This looks really good. Ideally the init method would have a docstring explaining the purpose of the 'undo' argument.

Potentially, the argument should be called something like "restore_original_dimension_ordering_on_undo" which, while verbose, is pretty easy to understand. I'm open to suggestions.

The implementation looks great, thank you very much. Let's talk it through tomorrow and put the finishing touches on it then.

[edoyango]

no worries happy to rename the variable and add doc strings. Perhaps restore_dim_order_on_undo could be more succinct while retaining clarity?

[edoyango]

variable name changed and doc string added!