Repository navigation
ethrpc: remove unused jwtToken field - #224
Merged
Merged
Conversation
Nothing sets it, so the Authorization header branch never ran. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
taylanpince
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ethrpc: remove unused jwtToken field
Provider.jwtTokenis never set. Its last setter,WithJWTAuthorization, was removed in 83b5ab7 (#161). Since then theAuthorization: BEARERbranch inDo()has been dead code.The field is unexported, so nothing outside
ethrpccan set it. No API change.Follow-up: a separate PR adds
ethrpc.WithHTTPAuth(rpc.HTTPAuth), mirroring go-ethereum'srpc.WithHTTPAuth. It applies auth to both HTTP requests and the WebSocket handshake.🤖 This message was generated by Claude using Opus 5.5 on behalf of Vojtech.