Repository navigation
Conversation
Add skills/splits-v2/SKILL.md plus a reference for distributing splits the caller did not create. Draft only; facts limited to the verified-facts ledger. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WmTHDeVKp4PcqbpqhvBGME
Mainnet runs on Arc showed a Pull split keeps 1 unit in the contract and 1 in its own Warehouse bucket (plus rounding remainders), and each recipient's Warehouse bucket keeps 1 that is carried into the next withdraw. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WmTHDeVKp4PcqbpqhvBGME
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
zherring
marked this pull request as ready for review
October 26, 2026 15:11
A blocklisted distributor only reverts a Push distribute when the fee is above 0, and a Pull split credits the distributor reward to the Warehouse (it needs a withdraw) instead of paying it out. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WmTHDeVKp4PcqbpqhvBGME
mihoward21
reviewed
Oct 26, 2026
mihoward21
left a comment
mihoward21
left a comment
Contributor
There was a problem hiding this comment.
@zherring couple notes
| - SDK: `SplitV2Client.getSplitMetadataViaProvider({ splitAddress, chainId })` rebuilds it from logs. On V2.1 and V2.2 it reads `updateBlockNumber()` and fetches that single block's logs, which works on Arc. | ||
| - Manual: call `updateBlockNumber()` on the split (V2.1 and V2.2, not V2.0), then `getLogs` for `SplitUpdated(Split)` from the split address at exactly that block. The latest config is the event at that block. The event is also emitted at creation. | ||
| - The SDK's data client path needs `apiConfig` and a subgraph-indexed chain; Arc is not one, so Arc always uses logs. | ||
| - Arc's public RPC caps `eth_getLogs` block ranges and rate-limits; prefer the single-block query. |
Contributor
There was a problem hiding this comment.
i think these are supposed to be generic docs? but they're kinda specific to arc. maybe chain specific things can go in a section at the bottom? or maybe there's some other way to structure it, but reads a bit odd right now
|
|
||
| ## 5. Pull withdrawals, per recipient | ||
|
|
||
| - Call `WarehouseClient.withdraw({ ownerAddress, tokenAddress })` once per recipient (and the distributor, if it earned a fee), per token id. |
Contributor
There was a problem hiding this comment.
is it worth referencing / linking to the sdk docs? i assume this file is for agents, right? i think having a high level thing to guide them makes sense, but may also be helpful to direct to the sdk docs for details: https://splits.org/protocol/docs/sdk
NOTE: i don't know how agent friendly those are, they were written a while ago
| @@ -0,0 +1,90 @@ | |||
| --- | |||
| name: splits-v2 | |||
| description: Guides creating, updating, distributing, and withdrawing from Splits V2 push and pull splits and the Splits Warehouse using viem and @0xsplits/splits-sdk. Use when paying contributors or recipients from onchain revenue, choosing between push and pull splits, distributing a split someone else created, withdrawing Warehouse balances, using Splits on Arc, or choosing a USDC token id (the 0x3600 ERC-20 view versus the 0xEeee native sentinel). Covers safe defaults, dry runs, and where to read current contract addresses and SDK docs. | |||
Contributor
There was a problem hiding this comment.
same thing here, this feels too specific to Arc. Unless this is meant to be an arc specific skill, but let's name it appropriately then
| | Factor | Push | Pull | | ||
| | --- | --- | --- | | ||
| | Recipients | Few, known, always able to receive | Many, unknown, or able to be blocklisted or revert | | ||
| | Payout | `distribute` pays recipients directly | `distribute` credits the Warehouse; each recipient must withdraw | |
Contributor
There was a problem hiding this comment.
maybe worth mentioning that warehouse withdraws are permissionless? anyone can withdraw on behalf of the recipients. so you could do a pull split and still get funds into each recipients wallet if you wanted, its just more txs to do
Address review feedback on #106: - description and body are chain-neutral; Arc gets one pointer bullet - Arc rules move to references/arc.md (token ids, push/pull, SDK trap, RPC limits) - distribute-existing-split.md is generic and links the SDK docs - state that Warehouse withdraws are permissionless in the push/pull table Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WmTHDeVKp4PcqbpqhvBGME
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A first draft of a
splits-v2agent skill, atskills/splits-v2/:SKILL.md(90 lines): when to use it, push vs pull, creating a split, distributing and withdrawing, Arc-specific token-id rules, safety rules.references/distribute-existing-split.md: recovering a split's config, verifying it againstsplitHash(), and withdrawing for Pull splits.Arc asked for Splits skills. This is the thin version: it holds no contract addresses or other volatile values, and points at the docs for those.
Depends on
#105 (Networks section with the Arc page). The skill links to
networks/arc.md, which 404s until #105 is merged and deployed. Everything else it links to is live.How the claims were checked
The Arc and SDK claims were checked against deployed bytecode, the SDK source (6.7.0),
eth_callsimulations, and four real transactions on Arc mainnet (four 0.1 USDC splits: Pull and Push, funded by ERC-20 transfer and by native send). Still simulation-only: wrong-id withdraw reverting, blocklisted and reverting recipients, and mutable-owner flows (update, pause).Known caveats
distributorFeePercentmax is 6.5535. The existing SDK docs say "<10". The contract limit is auint16on a 1e6 scale, so 6.5535 is right; the docs need a separate fix.setPausevssetPaused,transferOwnershipvsinitiateControlTransfer, withdraw living onWarehouseClient). Those are not fixed here.npx skills add 0xSplits/docs, and whether agents actually invoke it. Skills are not reliably invoked, so the safety rules also live in the docs.Not in this PR
Fund-moving recovery scripts. They exist but have not had an engineering review, so they are deliberately not bundled.
🤖 Generated with Claude Code
https://claude.ai/code/session_01WmTHDeVKp4PcqbpqhvBGME