Repository navigation
fix(agentconnect-ui): agents leave approval links to the owner's own browser - #229
Merged
Merged
Conversation
…browser Codex opened an approval link in a browser it ran (sometimes a private window), where the owner isn't signed in, so the page asked them to sign in again. The instructions now say only the owner opens it, in their own signed-in browser.
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codex opened the approval link itself, in a browser it runs (sometimes a private window) where the owner isn't signed in, so the approval page asked for sign-in even though the owner was signed in in their own browser.
The buying instructions, and
nextonpending_approval, now say: only the owner approves; never open approval_url in an agent-run or private browser; if opening it for them, use their own signed-in browser.Tests: 290 pass.
🤖 Generated with Claude Code