Repository navigation
fix(agentconnect-ui): an approval past its expiry is expired, not sent on to agentcard - #228
Merged
Merged
Conversation
…t on to agentcard
Kernel keeps reporting an AgentCard authorization as awaiting approval after it
expires, so an old checkout's link opened AgentCard's page on a payment it can't
take ("malformed payment endpoint"). Check expires_at; approving an expired one
now settles it as failed and frees the agent to start again.
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kernel keeps reporting an AgentCard authorization as
awaiting_approvalafter itsexpires_at. An old checkout's approval link therefore still went to AgentCard, whose page refused it with "Refusing to pay: malformed payment endpoint" (yesterday's Noordcode authorization, expired at 18:10 UTC, opened today). Agents also kept treating that checkout as pending and wouldn't start a new one.expires_atcounts as expired:browser_checkout_statusreportsexpired, the browser closes and the approval is marked failed (nothing charged)./approvefirst settles the checkout, so an expired one shows "didn't go through, nothing was charged" instead of opening AgentCard.Tests: 290 pass, one new.
🤖 Generated with Claude Code