Repository navigation
fix(agentconnect-ui): one kernel wallet per agentcard user, and tie agentcard users to the wallet - #226
Merged
Conversation
…k one can't block the next
…gentcard users to the wallet
| // One card item per checkout. Kernel never lets a card whose outcome it can't | ||
| // tell (`recovery_required`) be reused or deleted, so a stuck one must not | ||
| // block the next checkout. | ||
| const cardKey = (checkoutId: string) => `card-${checkoutId}`; |
There was a problem hiding this comment.
CLAUDE.md still describes the old fixed key. It says the card item is checkout-card ("card item checkout-card with amount, currency and origin"), and this PR replaces that with one item per checkout (card-<checkoutId>) and one wallet item per AgentCard user (wallet-<userId>). Please update the Browser checkouts paragraph so it doesn't send the next reader looking for an item that no longer exists.
Lines 75 to 77 in c9f6a55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #225; merge that first, or merge this one, which contains it.
Staging is moving from AgentCard sandbox credentials to live ones, so the owner's AgentCard user changes. The Kernel wallet item was one per vault (
agentcard-wallet), and the code deleted it when the user changed. Kernel refuses to delete a wallet whose card isrecovery_required, and the staging wallet has one, so that would have blocked every checkout.wallet-<user id>). A new user gets a new item, and nothing is deleted.external_user_idon add-a-card sessions: the wallet address, so AgentCard ties its user to our wallet. AgentCard's API takes no verified email or sign-in from us; the cardholder's passkey stays theirs.Tests: 287 pass.
🤖 Generated with Claude Code