From 42bce1eefdae01a188ce0577a85688a71ca03b3f Mon Sep 17 00:00:00 2001 From: rameel Date: Fri, 2 Oct 2026 22:47:43 +0500 Subject: [PATCH] build: remove unnecessary CA1861 suppression --- .editorconfig | 2 -- tests/Ramstack.Parsing.Tests/ParsersTests.Separated.cs | 8 ++++---- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/.editorconfig b/.editorconfig index ffccaa5..4ff8849 100644 --- a/.editorconfig +++ b/.editorconfig @@ -25,10 +25,8 @@ dotnet_diagnostic.CA1304.severity = none dotnet_diagnostic.CA1305.severity = none dotnet_diagnostic.CA1311.severity = none -# CA1861: Avoid constant arrays as arguments # CA1866: Use char overload # Test inputs are built per test case; the performance of test code is irrelevant. -dotnet_diagnostic.CA1861.severity = none dotnet_diagnostic.CA1866.severity = none [benchmarks/**.cs] diff --git a/tests/Ramstack.Parsing.Tests/ParsersTests.Separated.cs b/tests/Ramstack.Parsing.Tests/ParsersTests.Separated.cs index 8f1e2ae..8a16d3a 100644 --- a/tests/Ramstack.Parsing.Tests/ParsersTests.Separated.cs +++ b/tests/Ramstack.Parsing.Tests/ParsersTests.Separated.cs @@ -165,7 +165,7 @@ public void Separated_TrailingEmptyPair_StopsAfterEmptyItem([Values] bool allowT var success = parser.TryParse(ref context, out var value); Assert.That(success, Is.True); - Assert.That(value, Is.EqualTo(new[] { 12, 7 })); + Assert.That(value, Is.EqualTo([12, 7])); Assert.That(item.Attempts, Is.EqualTo(2)); Assert.That(context.Position, Is.EqualTo(3)); @@ -206,7 +206,7 @@ public void Separated_OnlyItemConsumesInput_ContinuesParsing([Values] bool allow var result = parser.Parse("abc!"); Assert.That(result.Success, Is.True); - Assert.That(result.Value, Is.EqualTo(new[] { 'a', 'b', 'c' })); + Assert.That(result.Value, Is.EqualTo(['a', 'b', 'c'])); Assert.That(result.Length, Is.EqualTo(3)); } @@ -233,7 +233,7 @@ public void Separated_OnlySeparatorConsumesInput_ContinuesParsing([Values] bool var result = parser.Parse(",,!"); Assert.That(result.Success, Is.True); - Assert.That(result.Value, Is.EqualTo(new[] { 'x', 'x', 'x' })); + Assert.That(result.Value, Is.EqualTo(['x', 'x', 'x'])); Assert.That(result.Length, Is.EqualTo(2)); } @@ -260,7 +260,7 @@ public void Separated_MaximumReached_ConsumesTrailingSeparatorOnlyWhenAllowed(bo var success = parser.TryParse(ref context, out var value); Assert.That(success, Is.True); - Assert.That(value, Is.EqualTo(new[] { 'a' })); + Assert.That(value, Is.EqualTo(['a'])); Assert.That(context.Position, Is.EqualTo(expectedLength)); Assert.That(context.MatchedSegment.Index, Is.Zero); Assert.That(context.MatchedSegment.Length, Is.EqualTo(expectedLength));