From 37561271a35bf2a30e8bbbfc79ce56490123c473 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Maurycy=20Paw=C5=82owski-Wiero=C5=84ski?= Date: Thu, 19 Nov 2026 08:51:19 +0100 Subject: [PATCH] up --- Modules/mmapmodule.c | 22 ++++++++-------------- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/Modules/mmapmodule.c b/Modules/mmapmodule.c index ce5c59cb0212707..06099a3b8b2e0be 100644 --- a/Modules/mmapmodule.c +++ b/Modules/mmapmodule.c @@ -1567,22 +1567,16 @@ mmap_subscript_impl(mmap_object *self, PyObject *item) else if (step == 1) return _safe_PyBytes_FromStringAndSize(self->data + start, slicelen); else { - char *result_buf = (char *)PyMem_Malloc(slicelen); - PyObject *result; - - if (result_buf == NULL) - return PyErr_NoMemory(); - - if (safe_copy_to_slice(result_buf, self->data, start, step, - slicelen) < 0) - { - result = NULL; + PyBytesWriter *writer = PyBytesWriter_Create(slicelen); + if (writer == NULL) { + return NULL; } - else { - result = PyBytes_FromStringAndSize(result_buf, slicelen); + if (safe_copy_to_slice(PyBytesWriter_GetData(writer), self->data, + start, step, slicelen) < 0) { + PyBytesWriter_Discard(writer); + return NULL; } - PyMem_Free(result_buf); - return result; + return PyBytesWriter_Finish(writer); } } else {