From 35a78dd346dd532df07eb4d77dd692f10a2f9dd8 Mon Sep 17 00:00:00 2001 From: Victor Stinner Date: Wed, 18 Nov 2026 17:21:21 +0100 Subject: [PATCH 1/2] gh-162214: Define STRINGLIB_IS_UNICODE macro in Objects/bytes_methods.c Fix compiler warnings when Python is built with -Wundef: In file included from Objects/bytes_methods.c:386: Objects/stringlib/count.h:10:6: warning: 'STRINGLIB_IS_UNICODE' is not defined, evaluates to '0' [-Wundef] 10 | #if !STRINGLIB_IS_UNICODE || STRINGLIB_MAX_CHAR > 0x7Fu | ^~~~~~~~~~~~~~~~~~~~ In file included from Objects/bytes_methods.c:388: Objects/stringlib/find_max_char.h:4:6: warning: 'STRINGLIB_IS_UNICODE' is not defined, evaluates to '0' [-Wundef] 4 | #if !STRINGLIB_IS_UNICODE && STRINGLIB_SIZEOF_CHAR > 1 | ^~~~~~~~~~~~~~~~~~~~ --- Objects/bytes_methods.c | 1 + 1 file changed, 1 insertion(+) diff --git a/Objects/bytes_methods.c b/Objects/bytes_methods.c index 414afeb7bb003c..868353cd1b851b 100644 --- a/Objects/bytes_methods.c +++ b/Objects/bytes_methods.c @@ -377,6 +377,7 @@ _Py_bytes_maketrans(Py_buffer *frm, Py_buffer *to) } #define FASTSEARCH fastsearch +#define STRINGLIB_IS_UNICODE 0 #define STRINGLIB(F) stringlib_##F #define STRINGLIB_CHAR char #define STRINGLIB_SIZEOF_CHAR 1 From fb04c798b701f15a82a62bd782c5ee0b610706a4 Mon Sep 17 00:00:00 2001 From: Victor Stinner Date: Wed, 18 Nov 2026 22:09:58 +0100 Subject: [PATCH 2/2] Remove some spaces --- Objects/bytes_methods.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Objects/bytes_methods.c b/Objects/bytes_methods.c index 868353cd1b851b..4021a0e8223694 100644 --- a/Objects/bytes_methods.c +++ b/Objects/bytes_methods.c @@ -377,7 +377,7 @@ _Py_bytes_maketrans(Py_buffer *frm, Py_buffer *to) } #define FASTSEARCH fastsearch -#define STRINGLIB_IS_UNICODE 0 +#define STRINGLIB_IS_UNICODE 0 #define STRINGLIB(F) stringlib_##F #define STRINGLIB_CHAR char #define STRINGLIB_SIZEOF_CHAR 1