From 3941b249b451e6c4d45da58e6c4d3f4d576191d2 Mon Sep 17 00:00:00 2001 From: Junaid Ahamed Date: Wed, 18 Nov 2026 05:12:50 +0530 Subject: [PATCH] gh-91601: Use host addresses for IP interface reverse DNS names --- Lib/ipaddress.py | 6 ++++++ Lib/test/test_ipaddress.py | 19 +++++++++++++++++++ ...11-17-23-29-00.gh-issue-91601.IfacePTR.rst | 3 +++ 3 files changed, 28 insertions(+) create mode 100644 Misc/NEWS.d/next/Library/2026-11-17-23-29-00.gh-issue-91601.IfacePTR.rst diff --git a/Lib/ipaddress.py b/Lib/ipaddress.py index 3421c9f40ce843f..0b18aeb4310f209 100644 --- a/Lib/ipaddress.py +++ b/Lib/ipaddress.py @@ -1538,6 +1538,9 @@ def __hash__(self): def ip(self): return IPv4Address(self._ip) + def _reverse_pointer(self): + return self.ip.reverse_pointer + @property def with_prefixlen(self): return '%s/%s' % (self._string_from_ip_int(self._ip), @@ -2343,6 +2346,9 @@ def __hash__(self): def ip(self): return IPv6Address(self._ip) + def _reverse_pointer(self): + return self.ip.reverse_pointer + @property def with_prefixlen(self): return '%s/%s' % (self._string_from_ip_int(self._ip), diff --git a/Lib/test/test_ipaddress.py b/Lib/test/test_ipaddress.py index 4b398c1f41ef602..7c3568553181a88 100644 --- a/Lib/test/test_ipaddress.py +++ b/Lib/test/test_ipaddress.py @@ -2852,6 +2852,25 @@ def testReversePointer(self): addr = ipaddress.IPv6Address(addr_v6) self.assertEqual(addr.reverse_pointer, expected) + def testReversePointerInterface(self): + cases = [ + ('192.0.2.1', '1.2.0.192.in-addr.arpa', (0, 24, 32)), + ('4321:0:1:2:3:4:567:89ab', + 'b.a.9.8.7.6.5.0.4.0.0.0.3.0.0.0.' + '2.0.0.0.1.0.0.0.0.0.0.0.1.2.3.4.ip6.arpa', (0, 64, 128)), + ('4321:0:1:2:3:4:567:89ab%eth0', + 'b.a.9.8.7.6.5.0.4.0.0.0.3.0.0.0.' + '2.0.0.0.1.0.0.0.0.0.0.0.1.2.3.4.ip6.arpa', (0, 64, 128)), + ('::ffff:192.0.2.1', + '1.0.2.0.0.0.0.c.f.f.f.f.0.0.0.0.' + '0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.ip6.arpa', (0, 96, 128)), + ] + for address, expected, prefixes in cases: + for prefix in prefixes: + with self.subTest(address=address, prefix=prefix): + interface = ipaddress.ip_interface(f'{address}/{prefix}') + self.assertEqual(interface.reverse_pointer, expected) + def testIntRepresentation(self): self.assertEqual(16909060, int(self.ipv4_address)) self.assertEqual(42540616829182469433547762482097946625, diff --git a/Misc/NEWS.d/next/Library/2026-11-17-23-29-00.gh-issue-91601.IfacePTR.rst b/Misc/NEWS.d/next/Library/2026-11-17-23-29-00.gh-issue-91601.IfacePTR.rst new file mode 100644 index 000000000000000..cdd02add7b03427 --- /dev/null +++ b/Misc/NEWS.d/next/Library/2026-11-17-23-29-00.gh-issue-91601.IfacePTR.rst @@ -0,0 +1,3 @@ +Fix :attr:`~ipaddress.IPv4Address.reverse_pointer` on +:class:`ipaddress.IPv4Interface` and :class:`ipaddress.IPv6Interface` to use +the host address without the network prefix.